Skip to content

Subscribable types and subtypes v1<>v1alpha1 conversion#3477

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
aliok:duck_conv_06_v1alpha_v1_conversion
Jul 9, 2020
Merged

Subscribable types and subtypes v1<>v1alpha1 conversion#3477
knative-prow-robot merged 1 commit into
knative:masterfrom
aliok:duck_conv_06_v1alpha_v1_conversion

Conversation

@aliok
Copy link
Copy Markdown
Member

@aliok aliok commented Jul 3, 2020

Final step of #3474

@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 3, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 3, 2020
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2020
@aliok aliok force-pushed the duck_conv_06_v1alpha_v1_conversion branch from 1ebf34a to 7d70037 Compare July 6, 2020 06:45
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2020
@aliok aliok force-pushed the duck_conv_06_v1alpha_v1_conversion branch from 7d70037 to 8c319ac Compare July 8, 2020 14:37
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 8, 2020
@aliok aliok force-pushed the duck_conv_06_v1alpha_v1_conversion branch from 8c319ac to 6718dce Compare July 8, 2020 14:51
@aliok aliok changed the title [WIP] Subscribable types and subtypes v1<>v1alpha1 conversion Subscribable types and subtypes v1<>v1alpha1 conversion Jul 8, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2020
@aliok
Copy link
Copy Markdown
Member Author

aliok commented Jul 8, 2020

Rebased

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/duck/v1alpha1/subscribable_types_conversion.go 91.2% 86.4% -4.7

@knative-test-reporter-robot
Copy link
Copy Markdown

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-upgrade-tests pull-knative-eventing-upgrade-tests
pull-knative-eventing-upgrade-tests
pull-knative-eventing-upgrade-tests
pull-knative-eventing-upgrade-tests
3/3

Job pull-knative-eventing-upgrade-tests expended all 3 retries without success.

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jul 9, 2020

Thanks for all these!
/lgtm
/approve
/test pull-knative-eventing-upgrade-tests

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 9, 2020
@knative-prow-robot knative-prow-robot merged commit cfcc52d into knative:master Jul 9, 2020
@aliok aliok deleted the duck_conv_06_v1alpha_v1_conversion branch April 28, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants