Skip to content

Remove unused code that parsed multichannelfanout.Config from a string.#3713

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
Harwayne:remove-multichannelfanout-parse
Jul 26, 2020
Merged

Remove unused code that parsed multichannelfanout.Config from a string.#3713
knative-prow-robot merged 1 commit into
knative:masterfrom
Harwayne:remove-multichannelfanout-parse

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne commented Jul 24, 2020

Proposed Changes

  • Remove unused code that parsed multichannelfanout.Config from a string.
    • No longer used now that the IMC dispatcher uses an informer, rather than reading from a ConfigMap.

Release Note

NONE

@Harwayne
Remove unused code that parsed multichannelfanout.Config from a string.
6fae394 
No longer used now that the IMC dispatcher uses an informer, rather than reading from a ConfigMap.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 24, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 24, 2020
antoineco
antoineco approved these changes Jul 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 9c16bdb into knative:master Jul 26, 2020
@slinkydeveloper slinkydeveloper mentioned this pull request Jul 27, 2020
Merged
@Harwayne Harwayne deleted the remove-multichannelfanout-parse branch July 27, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

1 more reviewer

@antoineco antoineco antoineco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antoineco antoineco

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Harwayne @knative-prow-robot @antoineco @googlebot