Skip to content

kubectl explain for Broker#3848

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
nlopezgi:issue-3054-7
Aug 14, 2020
Merged

kubectl explain for Broker#3848
knative-prow-robot merged 1 commit into
knative:masterfrom
nlopezgi:issue-3054-7

Conversation

@nlopezgi
Copy link
Copy Markdown
Contributor

@nlopezgi nlopezgi commented Aug 14, 2020

Part of #3054

Proposed Changes

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 14, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 14, 2020
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2020
@pierDipi
Copy link
Copy Markdown
Member

/cc @lionelvillard
/retitle "kubectl explain for Broker"

@nlopezgi nlopezgi changed the title [WIP] kubectl explain for Broker kubectl explain for Broker Aug 14, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2020
@nlopezgi
Copy link
Copy Markdown
Contributor Author

this is now passing and ready to be merged fyi @lionelvillard

@lionelvillard
Copy link
Copy Markdown
Contributor

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, nlopezgi, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2020
@knative-prow-robot knative-prow-robot merged commit 82e15e3 into knative:master Aug 14, 2020
@nlopezgi nlopezgi deleted the issue-3054-7 branch August 14, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants