[WIP] JSON Schema trigger filters implementation#4529
Closed
slinkydeveloper wants to merge 1 commit intoknative:mainfrom
Closed
[WIP] JSON Schema trigger filters implementation#4529slinkydeveloper wants to merge 1 commit intoknative:mainfrom
slinkydeveloper wants to merge 1 commit intoknative:mainfrom
Conversation
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/XXL
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
The following is the coverage report on the affected files.
|
Codecov Report
@@ Coverage Diff @@
## master #4529 +/- ##
==========================================
- Coverage 81.27% 81.15% -0.13%
==========================================
Files 284 285 +1
Lines 8017 8054 +37
==========================================
+ Hits 6516 6536 +20
- Misses 1113 1124 +11
- Partials 388 394 +6
Continue to review full report at Codecov.
|
slinkydeveloper
added a commit
to slinkydeveloper/eventing
that referenced
this pull request
Nov 16, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Contributor
Author
|
Raw values: Benchstat: |
Contributor
Author
|
Comments of the results with a comparison with json schema proposal https://docs.google.com/document/d/1Pz2vaLWKUrMQDLNyDW7ksjgLG4GAxBY546dT7_jF5Rk/edit#heading=h.nqj7kw3uqc6m |
Member
|
@slinkydeveloper is this still the direction we were looking to go? should we still have this WIP open? |
Contributor
Author
|
I'm not focused on this anymore, although I think we should keep it open, since it's working and it's a viable solution :) |
Contributor
|
@slinkydeveloper: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow-robot
added
the
needs-rebase
Contributor
|
@slinkydeveloper: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
8 tasks
|
This Pull Request is stale because it has been open for 90 days with |
github-actions
bot
added
the
lifecycle/stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Fixes #4495
This PR is WIP, I want to test the differences in terms of usability and performances with the #3783
Proposed Changes
Release Note
TODO