Skip to content

feat/upgrade-test: Add configurable broker deployment options#4616

Merged
knative-prow-robot merged 3 commits intoknative:masterfrom
zhongduo:upgrade-add-broker-option
Jan 5, 2021
Merged

feat/upgrade-test: Add configurable broker deployment options#4616
knative-prow-robot merged 3 commits intoknative:masterfrom
zhongduo:upgrade-add-broker-option

Conversation

@zhongduo
Copy link
Contributor

@zhongduo zhongduo commented Dec 1, 2020

Fixes #4612

Proposed Changes

  • Add BrokerOptions to probe configuration

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 1, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #4616 (60ad149) into master (da18ee0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4616   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files         290      290           
  Lines        8176     8176           
=======================================
  Hits         6648     6648           
  Misses       1128     1128           
  Partials      400      400           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da18ee0...03d178f. Read the comment docs.

@zhongduo
Copy link
Contributor Author

zhongduo commented Dec 1, 2020

/retest

@zhongduo zhongduo changed the title feat/upgrade-test: Add configurable broker deployment options WIP: feat/upgrade-test: Add configurable broker deployment options Dec 1, 2020
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2020
@zhongduo zhongduo changed the title WIP: feat/upgrade-test: Add configurable broker deployment options feat/upgrade-test: Add configurable broker deployment options Dec 2, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2020
@zhongduo
Copy link
Contributor Author

zhongduo commented Dec 2, 2020

/assign @cardil

@matzew
Copy link
Member

matzew commented Dec 2, 2020

/approve

leaving the final review to @cardil

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@tayarani
Copy link
Contributor

tayarani commented Dec 2, 2020

You're adding the new config option, but I don't see it being used anywhere. Is it possible to add a test which uses this?

@zhongduo
Copy link
Contributor Author

zhongduo commented Dec 3, 2020

@cardil with this and #4615 the prober code can be easily adapted to test different configurations and broker types.

@zhongduo
Copy link
Contributor Author

zhongduo commented Jan 5, 2021

Pinging after New Year @cardil

Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, matzew, zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 0c47fa7 into knative:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[upgrade-test] allow configurable broker type

5 participants