feat/upgrade-test: Add configurable broker deployment options#4616
feat/upgrade-test: Add configurable broker deployment options#4616knative-prow-robot merged 3 commits intoknative:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4616 +/- ##
=======================================
Coverage 81.31% 81.31%
=======================================
Files 290 290
Lines 8176 8176
=======================================
Hits 6648 6648
Misses 1128 1128
Partials 400 400 Continue to review full report at Codecov.
|
|
/retest |
|
/assign @cardil |
|
/approve leaving the final review to @cardil |
|
You're adding the new config option, but I don't see it being used anywhere. Is it possible to add a test which uses this? |
|
Pinging after New Year @cardil |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, matzew, zhongduo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #4612
Proposed Changes