Skip to content

Comments

[master] Upgrade to latest dependencies#4848

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
knative-automation:auto-updates/update-deps-master
Feb 8, 2021
Merged

[master] Upgrade to latest dependencies#4848
knative-prow-robot merged 1 commit intoknative:masterfrom
knative-automation:auto-updates/update-deps-master

Conversation

@knative-automation
Copy link
Contributor

Cron. -knative-prow-robot

/cc knative/eventing-writers
/assign knative/eventing-writers

Produced via:

./hack/update-deps.sh --upgrade --release v0.21
./hack/update-codegen.sh

Details:

bumping knative.dev/pkg 6045ed4...4b2ae07:
  > 4b2ae07 Replace deprecated github.com/markbates/inflect with github.com/gobuffalo/flect (# 2014)
  > 8878069 upgrade to latest dependencies (# 2010)
  > c493a9e Update common github actions (# 2009)

bumping knative.dev/pkg 6045ed4...4b2ae07:
  > 4b2ae07 Replace deprecated github.com/markbates/inflect with github.com/gobuffalo/flect (# 2014)
  > 8878069 upgrade to latest dependencies (# 2010)
  > c493a9e Update common github actions (# 2009)

Signed-off-by: Knative Automation <automation@knative.team>
@knative-prow-robot knative-prow-robot requested a review from a team February 8, 2021 13:20
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 8, 2021
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #4848 (8813f77) into master (daa085d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4848   +/-   ##
=======================================
  Coverage   81.29%   81.29%           
=======================================
  Files         292      292           
  Lines        8326     8326           
=======================================
  Hits         6769     6769           
  Misses       1147     1147           
  Partials      410      410           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daa085d...a837e29. Read the comment docs.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@lionelvillard
Copy link
Contributor

/hold

I want to rerun the kind tests

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021
@lionelvillard
Copy link
Contributor

probably just a fluke.
/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021
@pierDipi
Copy link
Member

pierDipi commented Feb 8, 2021

I saw this one worked: https://github.com/knative/eventing/pull/4848/checks?check_run_id=1854970499 (same k8s version)

@knative-prow-robot knative-prow-robot merged commit b887ac4 into knative:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants