Skip to content

Comments

Remove Harwayne from OWNERS.#4860

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
Harwayne:remove-harwayne
Feb 9, 2021
Merged

Remove Harwayne from OWNERS.#4860
knative-prow-robot merged 1 commit intoknative:masterfrom
Harwayne:remove-harwayne

Conversation

@Harwayne
Copy link
Contributor

@Harwayne Harwayne commented Feb 9, 2021

Proposed Changes

Release Note

NONE

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 9, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2021
@knative-prow-robot
Copy link
Contributor

Hi @Harwayne. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@antoineco
Copy link
Contributor

antoineco commented Feb 9, 2021

😿

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #4860 (62abb2e) into master (f1d55ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4860   +/-   ##
=======================================
  Coverage   81.30%   81.30%           
=======================================
  Files         292      292           
  Lines        8319     8319           
=======================================
  Hits         6764     6764           
  Misses       1146     1146           
  Partials      409      409           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d55ad...f410453. Read the comment docs.

@vaikas
Copy link
Contributor

vaikas commented Feb 9, 2021

/ok-to-test
/lgtm
/approve
😢 Thanks for everything @Harwayne !!!

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2021
@knative-prow-robot knative-prow-robot merged commit f777623 into knative:master Feb 9, 2021
@Harwayne Harwayne deleted the remove-harwayne branch February 9, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants