Skip to content

WIP: Try to remove artificial sleeps#5066

Closed
matzew wants to merge 1 commit into
knative:mainfrom
matzew:remove_artificial_sleep
Closed

WIP: Try to remove artificial sleeps#5066
matzew wants to merge 1 commit into
knative:mainfrom
matzew:remove_artificial_sleep

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Mar 15, 2021

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Fixes #

Proposed Changes

  • trying/removing an old old sleep statement....

Release Note


Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2021
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 15, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Mar 15, 2021
@matzew matzew force-pushed the remove_artificial_sleep branch from f73d0a7 to 72e0ab7 Compare March 15, 2021 15:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 15, 2021

Codecov Report

Merging #5066 (19dc2f6) into main (ab3978c) will increase coverage by 0.53%.
The diff coverage is n/a.

❗ Current head 19dc2f6 differs from pull request most recent head 28ff5cf. Consider uploading reports for the commit 28ff5cf to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5066      +/-   ##
==========================================
+ Coverage   82.78%   83.31%   +0.53%     
==========================================
  Files         197      243      +46     
  Lines        6093     6917     +824     
==========================================
+ Hits         5044     5763     +719     
- Misses        724      801      +77     
- Partials      325      353      +28     
Impacted Files Coverage Δ
pkg/apis/messaging/v1/subscription_defaults.go 33.33% <0.00%> (-66.67%) ⬇️
pkg/duck/listable.go 63.38% <0.00%> (-19.72%) ⬇️
pkg/apis/sources/v1/apiserver_validation.go 85.71% <0.00%> (-14.29%) ⬇️
pkg/eventfilter/attributes/filter.go 86.36% <0.00%> (-13.64%) ⬇️
pkg/broker/ingress/ingress_handler.go 62.76% <0.00%> (-11.75%) ⬇️
pkg/apis/messaging/config/channel_defaults.go 65.00% <0.00%> (-10.00%) ⬇️
pkg/duck/channel.go 54.54% <0.00%> (-9.10%) ⬇️
pkg/adapter/v2/cloudevents.go 75.00% <0.00%> (-9.05%) ⬇️
pkg/apis/config/defaults.go 85.71% <0.00%> (-7.15%) ⬇️
pkg/apis/messaging/v1/subscription_validation.go 81.39% <0.00%> (-3.61%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db83525...28ff5cf. Read the comment docs.

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Mar 15, 2021

/test pull-knative-eventing-conformance-tests

/test pull-knative-eventing-integration-tests

@pierDipi
Copy link
Copy Markdown
Member

A related experiment that didn't go well #3898

/retest

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Mar 16, 2021

/retest

@matzew matzew force-pushed the remove_artificial_sleep branch from 72e0ab7 to 49e5721 Compare April 7, 2021 15:15
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Apr 9, 2021

/test all

@matzew matzew force-pushed the remove_artificial_sleep branch from 49e5721 to 19dc2f6 Compare April 9, 2021 14:33
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Apr 27, 2021

/retest

@matzew
Copy link
Copy Markdown
Member Author

matzew commented May 3, 2021

/test pull-knative-eventing-conformance-tests

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the remove_artificial_sleep branch from 19dc2f6 to 28ff5cf Compare June 7, 2021 16:00
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 7, 2021

/test pull-knative-eventing-conformance-tests

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@matzew: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-conformance-tests 28ff5cf link /test pull-knative-eventing-conformance-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 7, 2021

/close

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@matzew: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants