Skip to content

Comments

Add information about retryable error in servermanager#6921

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
creydr:add-information-about-retryable-error
May 8, 2023
Merged

Add information about retryable error in servermanager#6921
knative-prow[bot] merged 1 commit intoknative:mainfrom
creydr:add-information-about-retryable-error

Conversation

@creydr
Copy link
Member

@creydr creydr commented May 5, 2023

Adding some information about the returned status code (follow up on #6908)

Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@knative-prow knative-prow bot requested review from lberk and odacremolbap May 5, 2023 11:35
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 5, 2023
@creydr
Copy link
Member Author

creydr commented May 5, 2023

/test upgrade-tests
/assign @matzew @gab-satchi @pierDipi

Copy link
Contributor

@gab-satchi gab-satchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2023
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow
Copy link

knative-prow bot commented May 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, gab-satchi, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2023
@pierDipi
Copy link
Member

pierDipi commented May 5, 2023

/test upgrade-tests

1 similar comment
@creydr
Copy link
Member Author

creydr commented May 8, 2023

/test upgrade-tests

@knative-prow knative-prow bot merged commit d18cb42 into knative:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants