Skip to content

Fix deps upgrade#8620

Merged
knative-prow[bot] merged 2 commits into
knative:mainfrom
Cali0707:fix-deps-20250707
Jul 8, 2025
Merged

Fix deps upgrade#8620
knative-prow[bot] merged 2 commits into
knative:mainfrom
Cali0707:fix-deps-20250707

Conversation

@Cali0707
Copy link
Copy Markdown
Member

@Cali0707 Cali0707 commented Jul 7, 2025

Fixes the deps upgrade. From conversation knative/pkg#3211, in a recent pkg PR the default string parsing for configmaps was changed, breaking our multi-line string parsing for broker channel template configs. It was decided to change the parser here, rather than revert the behaviour in pkg

Proposed Changes

  • Update deps
  • Add a parser for a multiline string to fix configmap parsing

Cali0707 added 2 commits July 7, 2025 16:32
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 7, 2025
@knative-prow knative-prow Bot requested review from aslom and pierDipi July 7, 2025 20:35
@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.36%. Comparing base (1a736e1) to head (50d7f9a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8620      +/-   ##
==========================================
+ Coverage   52.35%   52.36%   +0.01%     
==========================================
  Files         399      399              
  Lines       25070    25076       +6     
==========================================
+ Hits        13126    13132       +6     
  Misses      11143    11143              
  Partials      801      801              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Cali0707
Copy link
Copy Markdown
Member Author

Cali0707 commented Jul 8, 2025

/cc @matzew @dsimansk

@knative-prow knative-prow Bot requested review from dsimansk and matzew July 8, 2025 12:48
@Cali0707
Copy link
Copy Markdown
Member Author

Cali0707 commented Jul 8, 2025

/cc @aliok @dprotaso @evankanderson

Copy link
Copy Markdown
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Copy Markdown
Member Author

Cali0707 commented Jul 8, 2025

/test reconciler-tests

@knative-prow knative-prow Bot merged commit 50d5a26 into knative:main Jul 8, 2025
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants