hack: quote YAML_OUTPUT_DIR in rm command to prevent word-splitting#8990
hack: quote YAML_OUTPUT_DIR in rm command to prevent word-splitting#8990Ankitsinghsisodya wants to merge 2 commits intoknative:mainfrom
Conversation
Without quotes, a path containing spaces causes incorrect glob expansion and may silently delete the wrong files or fail unexpectedly.
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Updates the YAML generation helper script to avoid shell word-splitting risks when cleaning the output directory.
Changes:
- Quote
${YAML_OUTPUT_DIR}in therm -frcleanup command to safely handle paths containing spaces.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya, evankanderson The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Ankitsinghsisodya: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes #8989
Summary
${YAML_OUTPUT_DIR}in therm -frcall inhack/generate-yamls.shWithout quotes, a path containing spaces causes word-splitting and may silently delete files in the wrong location.