Skip to content

hack: quote YAML_OUTPUT_DIR in rm command to prevent word-splitting#8990

Open
Ankitsinghsisodya wants to merge 2 commits intoknative:mainfrom
Ankitsinghsisodya:fix/quote-yaml-output-dir
Open

hack: quote YAML_OUTPUT_DIR in rm command to prevent word-splitting#8990
Ankitsinghsisodya wants to merge 2 commits intoknative:mainfrom
Ankitsinghsisodya:fix/quote-yaml-output-dir

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown

Fixes #8989

Summary

  • Quote ${YAML_OUTPUT_DIR} in the rm -fr call in hack/generate-yamls.sh

Without quotes, a path containing spaces causes word-splitting and may silently delete files in the wrong location.

Without quotes, a path containing spaces causes incorrect glob
expansion and may silently delete the wrong files or fail unexpectedly.
Copilot AI review requested due to automatic review settings April 1, 2026 10:23
@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Apr 1, 2026
@knative-prow knative-prow bot requested review from creydr and evankanderson April 1, 2026 10:23
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 1, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the YAML generation helper script to avoid shell word-splitting risks when cleaning the output directory.

Changes:

  • Quote ${YAML_OUTPUT_DIR} in the rm -fr cleanup command to safely handle paths containing spaces.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya, evankanderson
Once this PR has been reviewed and has the lgtm label, please assign upodroid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 2, 2026

@Ankitsinghsisodya: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_eventing_main 2ebb215 link true /test unit-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hack: unquoted ${YAML_OUTPUT_DIR} in rm command is a word-splitting risk

3 participants