fix: restore ARTIFACTS_TO_PUBLISH in release.sh to fix nightly releases#9040
Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom Apr 22, 2026
Merged
Conversation
PR knative#9018 replaced ARTIFACTS_TO_PUBLISH with a local `artifacts` array, but the vendored knative.dev/hack/release.sh relies on this global variable for image signing, checksums generation, and artifact publishing. With it unset, sign_release() had no files to process, breaking nightly release jobs.
knative-prow
Bot
added
approved
Member
Author
|
/cc @dprotaso |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9040 +/- ##
==========================================
- Coverage 50.50% 50.49% -0.02%
==========================================
Files 409 409
Lines 27505 27505
==========================================
- Hits 13891 13888 -3
- Misses 12751 12753 +2
- Partials 863 864 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
/test upgrade-tests_eventing_main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #9018 we replaced
ARTIFACTS_TO_PUBLISHwith a localartifactsarray, but the vendoredknative.dev/hack/release.shrelies on this global variable for image signing, checksums generation, and artifact publishing. With it unset, sign_release() had no files to process, breaking nightly release jobs.This should help on the current nightly release failures: https://prow.knative.dev/view/gs/knative-prow/logs/nightly_eventing_main_periodic/2046879002605391872