ci: add workflow_dispatch for manual reruns#9044
ci: add workflow_dispatch for manual reruns#9044Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Conversation
Allows maintainers to re-trigger the KinD e2e and downstream unit test workflows directly from the GitHub Actions UI without needing a dummy commit, which is useful for investigating flakes.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds manual triggers to existing GitHub Actions workflows so maintainers can rerun them from the Actions UI without pushing new commits (useful for investigating flakes).
Changes:
- Added
workflow_dispatchto the Downstream workflow trigger list - Added
workflow_dispatchto the KinD e2e workflow trigger list
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/knative-downstream.yaml | Adds workflow_dispatch to enable manual runs from the GitHub Actions UI |
| .github/workflows/kind-e2e.yaml | Adds workflow_dispatch to enable manual runs from the GitHub Actions UI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9044 +/- ##
==========================================
- Coverage 50.51% 50.50% -0.02%
==========================================
Files 409 409
Lines 27505 27505
==========================================
- Hits 13894 13891 -3
- Misses 12749 12751 +2
- Partials 862 863 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
98cce8a to
3fe6abe
Compare
creydr
left a comment
There was a problem hiding this comment.
I am not sure if this will allow users to retrigger workflow runs on PRs. IIRC this only allows to retrigger it on the actions overview page 🤔
I think it is more a repo setting
Yes sir, |
|
@creydr I was thinking that using comments to re-trigger CI over and over clutters the PR thread, whereas kicking off a run from the UI keeps the conversation clean. |
|
@creydr Is it possible for me to get access to re-run Knative’s CI? |
The permission settings are a small black box for me 🙈 I am not sure, but IIRC you need to be a maintainer of the project to be able to retrigger the actions via that button. |
I read about knative member thing. Seems cool 😅 |
Summary
workflow_dispatchtrigger tokind-e2e.yamlandknative-downstream.yamlTest plan