Skip to content

ci: add workflow_dispatch for manual reruns#9044

Open
Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Ankitsinghsisodya:ci/workflow-dispatch
Open

ci: add workflow_dispatch for manual reruns#9044
Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Ankitsinghsisodya:ci/workflow-dispatch

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor

@Ankitsinghsisodya Ankitsinghsisodya commented Apr 22, 2026

Summary

  • Adds workflow_dispatch trigger to kind-e2e.yaml and knative-downstream.yaml
  • Allows maintainers to re-trigger the KinD e2e and downstream unit test workflows directly from the GitHub Actions UI without needing a dummy commit, which is useful for investigating flakes

Test plan

  • Verify the "Run workflow" button appears in the GitHub Actions UI for both workflows after merge

Allows maintainers to re-trigger the KinD e2e and downstream unit test
workflows directly from the GitHub Actions UI without needing a dummy
commit, which is useful for investigating flakes.
Copilot AI review requested due to automatic review settings April 22, 2026 18:31
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya
Once this PR has been reviewed and has the lgtm label, please assign creydr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 22, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot requested review from Cali0707 and creydr April 22, 2026 18:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds manual triggers to existing GitHub Actions workflows so maintainers can rerun them from the Actions UI without pushing new commits (useful for investigating flakes).

Changes:

  • Added workflow_dispatch to the Downstream workflow trigger list
  • Added workflow_dispatch to the KinD e2e workflow trigger list

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/knative-downstream.yaml Adds workflow_dispatch to enable manual runs from the GitHub Actions UI
.github/workflows/kind-e2e.yaml Adds workflow_dispatch to enable manual runs from the GitHub Actions UI

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.50%. Comparing base (7c4c338) to head (d661d63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9044      +/-   ##
==========================================
- Coverage   50.51%   50.50%   -0.02%     
==========================================
  Files         409      409              
  Lines       27505    27505              
==========================================
- Hits        13894    13891       -3     
- Misses      12749    12751       +2     
- Partials      862      863       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Ankitsinghsisodya Ankitsinghsisodya force-pushed the ci/workflow-dispatch branch 2 times, most recently from 98cce8a to 3fe6abe Compare April 22, 2026 19:55
Copy link
Copy Markdown
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this will allow users to retrigger workflow runs on PRs. IIRC this only allows to retrigger it on the actions overview page 🤔
I think it is more a repo setting

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor Author

I am not sure if this will allow users to retrigger workflow runs on PRs. IIRC this only allows to retrigger it on the actions overview page 🤔 I think it is more a repo setting

Yes sir, workflow_dispatch is for manually starting a new run from the Actions tab (the “Run workflow” control on the workflow page).

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor Author

@creydr I was thinking that using comments to re-trigger CI over and over clutters the PR thread, whereas kicking off a run from the UI keeps the conversation clean.

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor Author

@creydr Is it possible for me to get access to re-run Knative’s CI?

@creydr
Copy link
Copy Markdown
Member

creydr commented Apr 23, 2026

@creydr Is it possible for me to get access to re-run Knative’s CI?

The permission settings are a small black box for me 🙈 I am not sure, but IIRC you need to be a maintainer of the project to be able to retrigger the actions via that button.
But as a member of the Knative org you would at least not be required for an ok-to-test from others

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor Author

@creydr Is it possible for me to get access to re-run Knative’s CI?

The permission settings are a small black box for me 🙈 I am not sure, but IIRC you need to be a maintainer of the project to be able to retrigger the actions via that button. But as a member of the Knative org you would at least not be required for an ok-to-test from others

I read about knative member thing. Seems cool 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants