ci: add path filters to skip KinD e2e on unrelated changes#9045
ci: add path filters to skip KinD e2e on unrelated changes#9045Ankitsinghsisodya wants to merge 3 commits intoknative:mainfrom
Conversation
knative-prow
Bot
added
size/XS
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds path-based filtering to the KinD e2e GitHub Actions workflow so it only runs on PRs that change runtime-relevant files, reducing unnecessary CI usage.
Changes:
- Add
pathsfilters to thepull_requesttrigger for the KinD e2e workflow - Restrict workflow execution to Go sources, Go deps, config, tests, and the workflow file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9045 +/- ##
==========================================
- Coverage 51.05% 51.04% -0.02%
==========================================
Files 409 409
Lines 21997 21997
==========================================
- Hits 11231 11228 -3
- Misses 9902 9906 +4
+ Partials 864 863 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ankitsinghsisodya
force-pushed
the
ci/path-filters
branch
from
b1efbc9 to
953a82d
Compare
| - 'go.sum' | ||
| - 'config/**' | ||
| - 'test/**' | ||
| - '.github/workflows/kind-e2e.yaml' |
There was a problem hiding this comment.
we also need hack/ as those scripts are used for cluster setup and third_party/ for cert-manager/eventing-integration updates for example
There was a problem hiding this comment.
done sir!!
The KinD e2e matrix (3 test suites × 2 k8s versions) currently fires on every PR regardless of what changed. Restricting it to paths that can actually affect runtime behaviour — Go source, go.mod/sum, config/, test/, and the workflow file itself — avoids wasting ~6 parallel runner-hours on documentation or tooling-only changes. The e2e-tests check is not a required status check on the upstream repo (Prow handles gating), so a skipped run on docs-only PRs does not block merging.
GitHub Actions path globs are minimatch-based; **/*.go is the unambiguous pattern for any .go file under the repo tree.
This update includes 'hack/**' and 'third_party/**' in the path filters for the KinD e2e workflow, ensuring that the tests only run for relevant changes and further optimizing resource usage during CI runs.
Ankitsinghsisodya
force-pushed
the
ci/path-filters
branch
from
ca0b254 to
5b46c5f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary
pathsfilters to thepull_requesttrigger inkind-e2e.yamlPaths that trigger the workflow:
**/*.go— any Go source changego.mod/go.sum— dependency changesconfig/**— Knative config YAMLstest/**— test helpers and fixtures.github/workflows/kind-e2e.yaml— the workflow file itselfNote:
e2e-testsis not a required status check on this repo (Prow handles gating viaconformance-tests_eventing_mainetc.), so a skipped run on docs-only PRs does not block merging.Test plan
.gofiles