Skip to content

fix: knative deployer should choose last built image by default #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

fix: knative deployer should choose last built image by default #3100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/knative/deployer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,16 @@ func (d *Deployer) Deploy(ctx context.Context, f fn.Function) (fn.DeploymentResu
return fn.DeploymentResult{}, fmt.Errorf("deployer requires either a target namespace or that the function be already deployed")
}

// Choosing an image to deploy:
// If the service has not been deployed before, but there exists a
// build image, this build image should be used for the deploy.
// TODO: test/consdier the case where it HAS been deployed, and the
// build image has been updated /since/ deployment: do we need a
// timestamp? Incrementation?
if f.Deploy.Image == "" {
f.Deploy.Image = f.Build.Image
}

// Clients
client, err := NewServingClient(namespace)
if err != nil {
Expand Down
Loading