Add middleware-version label on pack remote builds too#3609
Conversation
knative-prow
Bot
added
the
size/S
| if err := os.WriteFile("/tekton/results/middlewareVersion", []byte(middlewareVersion), 0644); err != nil { | ||
| return fmt.Errorf("cannot write middleware version as a result: %w", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
This is not needed anymore. This was for "inter-step" communication, but as we write the file in line 104 too, we can use this one too
|
/cc @gauron99 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
|
Requires #3610 |
creydr
force-pushed
the
add-middlewareversion-label-on-pack-remote-builds-too
branch
from
e7d7f8b to
f585abb
Compare
|
/lgtm |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3609 +/- ##
==========================================
- Coverage 56.26% 56.25% -0.01%
==========================================
Files 180 180
Lines 20522 20522
==========================================
- Hits 11546 11545 -1
- Misses 7774 7775 +1
Partials 1202 1202
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Fix the pack remote builder to add the middleware-version label too