Skip to content

Bump golangci-lint to 2.11.4#3610

Merged
knative-prow[bot] merged 2 commits intoknative:mainfrom
creydr:bump-golang-lint-to-2.11.4
Apr 15, 2026
Merged

Bump golangci-lint to 2.11.4#3610
knative-prow[bot] merged 2 commits intoknative:mainfrom
creydr:bump-golang-lint-to-2.11.4

Conversation

@creydr
Copy link
Copy Markdown
Member

@creydr creydr commented Apr 15, 2026

Default Go was bumped to 1.26 (knative/actions@8eec692) which causes the linter to panic.

@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos April 15, 2026 08:35
@knative-prow knative-prow Bot added the size/XS 🤖 PR changes 0-9 lines, ignoring generated files. label Apr 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.26%. Comparing base (9d28e3b) to head (b6fd0d4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/create.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3610   +/-   ##
=======================================
  Coverage   56.26%   56.26%           
=======================================
  Files         180      180           
  Lines       20522    20522           
=======================================
+ Hits        11546    11547    +1     
+ Misses       7774     7773    -1     
  Partials     1202     1202           
Flag Coverage Δ
e2e 36.21% <50.00%> (+0.01%) ⬆️
e2e go 32.84% <50.00%> (ø)
e2e node 28.59% <50.00%> (ø)
e2e python 33.21% <50.00%> (-0.01%) ⬇️
e2e quarkus 28.73% <50.00%> (ø)
e2e rust 28.14% <50.00%> (+0.02%) ⬆️
e2e springboot 26.61% <50.00%> (+0.02%) ⬆️
e2e typescript 28.72% <50.00%> (+0.02%) ⬆️
e2e-config-ci 18.07% <50.00%> (ø)
integration 17.45% <50.00%> (-0.01%) ⬇️
unit macos-14 43.30% <50.00%> (ø)
unit macos-latest 43.30% <50.00%> (ø)
unit ubuntu-24.04-arm 43.50% <50.00%> (ø)
unit ubuntu-latest 44.18% <50.00%> (ø)
unit windows-latest 43.33% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99
Copy link
Copy Markdown
Contributor

/retest

@gauron99 gauron99 closed this Apr 15, 2026
@gauron99 gauron99 reopened this Apr 15, 2026
Copy link
Copy Markdown
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Apr 15, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label Apr 15, 2026
@gauron99
Copy link
Copy Markdown
Contributor

required knative/actions#288 first

@knative-prow knative-prow Bot merged commit cc4317a into knative:main Apr 15, 2026
80 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants