cluster: Contour when --serving=false; drop dead delete --container-engine - #3985
Open
lkingland wants to merge 1 commit into
Open
cluster: Contour when --serving=false; drop dead delete --container-engine#3985lkingland wants to merge 1 commit into
lkingland wants to merge 1 commit into
Conversation
…ngine Post-knative#3856 follow-up (review S1/S2 landed after the squash merge): S1: Remove --container-engine from cluster delete — nothing read it after host registry teardown went away. S2: Extract installContour; when --serving=false install Contour before the registry so registry.localtest.me Ingress is not inert. Default --serving=true unchanged (hack/cluster.sh always has Contour via networking). Help text documents Contour on minimal create. Functions follow-up to #43 / knative#3856
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
knative-prow
Bot
added
the
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3856 (squash-merged at
c5310074before these review fixes landed on the PR tip).S1: Remove dead
--container-enginefromfunc cluster delete— nothing in the delete path readContainerEngineOverrideafter host registry container teardown was removed.S2: When
--serving=false, Contour was not installed, but the registry still applied an Ingress withingressClassName: contour-external. Hostdocker push registry.localtest.me/...then failed. ExtractinstallContourfrominstallNetworking; on the registry path, install Contour before the registry when Serving is off. Default--serving=trueunchanged (matcheshack/cluster.sh, which always installs Contour vianetworking). Help documents Contour on minimal create.Test plan
go build ./cmd/ ./pkg/cluster/func cluster createpath unchanged (Serving + Contour via svr)func cluster create --serving=false --eventing=falseinstalls Contour then registry; host registry hostname resolves via IngressFunctions#43 follow-up.