Exclude the control-plane from our webhooks for psbinding webhook.#1696
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Sep 9, 2020
Merged
Exclude the control-plane from our webhooks for psbinding webhook.#1696knative-prow-robot merged 1 commit intoknative:masterfrom
knative-prow-robot merged 1 commit intoknative:masterfrom
Conversation
knative-prow-robot
added
the
size/S
Member
|
/hold Link the Azure issue? |
knative-prow-robot
added
the
do-not-merge/hold
Contributor
Author
|
It is linked from our issue, but it is this one : Azure/AKS#1771 It is not clear it is an issue. They are doing a normal thing, and we are re-reconciling the object back to how we thing it should look. We should be smarter about mutation webhooks in general. |
Contributor
Author
|
/unhold |
knative-prow-robot
removed
the
do-not-merge/hold
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Contributor
|
/test pull-knative-pkg-unit-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not fight with azure's webhook for webhooks
Relates to #1590