Skip to content

Exclude the control-plane from our webhooks for psbinding webhook. #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Sep 9, 2020
Merged

Exclude the control-plane from our webhooks for psbinding webhook. #1696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions webhook/psbinding/psbinding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,11 @@ var (
Key: duck.BindingExcludeLabel,
Operator: metav1.LabelSelectorOpNotIn,
Values: []string{"true"},
}, {
// "control-plane" is added to support Azure's AKS, otherwise the controllers fight.
// See knative/pkg#1590 for details.
Key: "control-plane",
Operator: metav1.LabelSelectorOpDoesNotExist,
}},
// TODO(mattmoor): Consider also having a GVR-based one, e.g.
// foobindings.blah.knative.dev/exclude: "true"
Expand All @@ -143,6 +148,11 @@ var (
Key: duck.BindingIncludeLabel,
Operator: metav1.LabelSelectorOpIn,
Values: []string{"true"},
}, {
// "control-plane" is added to support Azure's AKS, otherwise the controllers fight.
// See knative/pkg#1590 for details.
Key: "control-plane",
Operator: metav1.LabelSelectorOpDoesNotExist,
}},
// TODO(mattmoor): Consider also having a GVR-based one, e.g.
// foobindings.blah.knative.dev/include: "true"
Expand Down