Skip to content

Make Kingress reconciled with DomainMapping when adding a new label#13178

Merged
knative-prow[bot] merged 2 commits into
knative:mainfrom
xxinran:adding-label
Aug 4, 2022
Merged

Make Kingress reconciled with DomainMapping when adding a new label#13178
knative-prow[bot] merged 2 commits into
knative:mainfrom
xxinran:adding-label

Conversation

@xxinran

@xxinran xxinran commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

Fixes #13135

Release Note

Fixed domain mapping reconciler to update the Kingress label when adding a new label to domain mapping. 

@knative-prow knative-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/API API objects and controllers labels Aug 3, 2022
@xxinran

xxinran commented Aug 3, 2022

Copy link
Copy Markdown
Contributor Author

/retest

@codecov

codecov Bot commented Aug 3, 2022

Copy link
Copy Markdown

Codecov Report

Merging #13178 (0ff85c7) into main (782df98) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #13178   +/-   ##
=======================================
  Coverage   86.70%   86.70%           
=======================================
  Files         196      196           
  Lines       14461    14463    +2     
=======================================
+ Hits        12538    12540    +2     
  Misses       1626     1626           
  Partials      297      297           
Impacted Files Coverage Δ
pkg/reconciler/domainmapping/reconciler.go 93.68% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@psschwei

psschwei commented Aug 3, 2022

Copy link
Copy Markdown
Member

/retest

@nak3

nak3 commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

Thank you so much! LGTM overall.
I guess we can add an unit test like this https://github.com/knative/serving/blob/main/pkg/reconciler/domainmapping/table_test.go#L415 ?

@knative-prow knative-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2022
@nak3

nak3 commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

/lgtm

Thank you! Finally, could you please write the release note on the first comment?

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2022
@xxinran

xxinran commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

/lgtm

Thank you! Finally, could you please write the release note on the first comment?

Sure, please check it.

@nak3

nak3 commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

/approve

@knative-prow

knative-prow Bot commented Aug 4, 2022

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, xxinran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@knative-prow
knative-prow Bot merged commit e600ae7 into knative:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kingress generated by DomainMapping is not reconciled when adding a new label to DomainMapping

3 participants