Skip to content

Add setup script for internal-encryption e2e test#13559

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
KauzClay:ck-internal-encryption-e2e-test-prep
Jan 12, 2023
Merged

Add setup script for internal-encryption e2e test#13559
knative-prow[bot] merged 1 commit into
knative:mainfrom
KauzClay:ck-internal-encryption-e2e-test-prep

Conversation

@KauzClay

@KauzClay KauzClay commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

Proposed Changes

Release Note

N/A

@knative-prow knative-prow Bot added area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2022
@codecov

codecov Bot commented Dec 16, 2022

Copy link
Copy Markdown

Codecov Report

Base: 86.43% // Head: 86.43% // No change to project coverage 👍

Coverage data is based on head (7305888) compared to base (35abde0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13559   +/-   ##
=======================================
  Coverage   86.43%   86.43%           
=======================================
  Files         196      196           
  Lines       14600    14600           
=======================================
  Hits        12619    12619           
  Misses       1680     1680           
  Partials      301      301           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KauzClay
KauzClay force-pushed the ck-internal-encryption-e2e-test-prep branch from b0a85df to 41d5803 Compare December 16, 2022 20:53
Comment thread test/e2e-internal-encryption-tests.sh Outdated
* test does nothing now, will be implemented in a later PR
@KauzClay
KauzClay force-pushed the ck-internal-encryption-e2e-test-prep branch from 41d5803 to 7305888 Compare December 16, 2022 21:25
@KauzClay

Copy link
Copy Markdown
Contributor Author

the kourier-tls e2e tests seem to be failing when they source test/e2e-common.sh. It breaks in this block: https://github.com/knative/serving/blob/main/test/e2e-common.sh#L64-L77

Based on what I see here (https://github.com/knative/serving/actions/runs/3716649646/jobs/6303260544#step:10:249), LATEST_SERVING_RELEASE_VERSION isn't set.

Idk where to find "latest_version" or how to find out what it is supposed to be there: https://github.com/knative/serving/blob/main/test/e2e-common.sh#L74

@krsna-m

krsna-m commented Dec 19, 2022

Copy link
Copy Markdown
Contributor

/retest

@krsna-m

krsna-m commented Dec 19, 2022

Copy link
Copy Markdown
Contributor

/approve

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2022
@KauzClay

Copy link
Copy Markdown
Contributor Author

/retest

@KauzClay

KauzClay commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

I believe the failures I'm seeing are related to #13566 (comment)

I don't think this is related to the change I'm trying to make, so do you think I can get the okay to have this merged? @kvmware

@psschwei

psschwei commented Jan 9, 2023

Copy link
Copy Markdown
Member

I retried the failing jobs... since they seem to be flakes, hopefully they'll pass this time (probably best not to override the tests if we don't have to)

@krsna-m

krsna-m commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

/retest

@KauzClay

Copy link
Copy Markdown
Contributor Author

Hey @psschwei , it looks like the tests passed. Do you feel comfortable giving it the okay?

@krsna-m

krsna-m commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2023

@psschwei psschwei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

(the HPA test in the istio prow job is running into some GKE issues, so 🤞 )

@knative-prow

knative-prow Bot commented Jan 11, 2023

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KauzClay, kvmware, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KauzClay

Copy link
Copy Markdown
Contributor Author

/test istio-latest-no-mesh

@knative-prow
knative-prow Bot merged commit fb0c4bd into knative:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants