Add setup script for internal-encryption e2e test#13559
Conversation
Codecov ReportBase: 86.43% // Head: 86.43% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #13559 +/- ##
=======================================
Coverage 86.43% 86.43%
=======================================
Files 196 196
Lines 14600 14600
=======================================
Hits 12619 12619
Misses 1680 1680
Partials 301 301 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b0a85df to
41d5803
Compare
* test does nothing now, will be implemented in a later PR
41d5803 to
7305888
Compare
|
the kourier-tls e2e tests seem to be failing when they source Based on what I see here (https://github.com/knative/serving/actions/runs/3716649646/jobs/6303260544#step:10:249), LATEST_SERVING_RELEASE_VERSION isn't set. Idk where to find "latest_version" or how to find out what it is supposed to be there: https://github.com/knative/serving/blob/main/test/e2e-common.sh#L74 |
|
/retest |
|
/approve |
|
/retest |
|
I believe the failures I'm seeing are related to #13566 (comment) I don't think this is related to the change I'm trying to make, so do you think I can get the okay to have this merged? @kvmware |
|
I retried the failing jobs... since they seem to be flakes, hopefully they'll pass this time (probably best not to override the tests if we don't have to) |
|
/retest |
|
Hey @psschwei , it looks like the tests passed. Do you feel comfortable giving it the okay? |
|
/lgtm |
psschwei
left a comment
There was a problem hiding this comment.
/approve
(the HPA test in the istio prow job is running into some GKE issues, so 🤞 )
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KauzClay, kvmware, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test istio-latest-no-mesh |
Proposed Changes
internal encryptionconfiguration knative-extensions/net-contour#819.Release Note