feat: use knative.dev/pkg/tls for reconciler TLS configuration#16431
Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom Mar 5, 2026
Merged
feat: use knative.dev/pkg/tls for reconciler TLS configuration#16431knative-prow[bot] merged 1 commit intoknative:mainfrom
knative-prow[bot] merged 1 commit intoknative:mainfrom
Conversation
knative-prow
bot
added
the
size/M
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16431 +/- ##
==========================================
+ Coverage 80.21% 80.22% +0.01%
==========================================
Files 217 217
Lines 13511 13503 -8
==========================================
- Hits 10838 10833 -5
+ Misses 2307 2304 -3
Partials 366 366 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
twoGiants
approved these changes
Mar 3, 2026
twoGiants
left a comment
twoGiants
left a comment
There was a problem hiding this comment.
This is out of scope as this is a TLS client and we should take care of servers only.
I have it in my notes under "Potential Future Work". But now that you did it we might as well keep it! 😆 👍
I have only one comment.
/approve
/lgtm
/hold for other reviewers
knative-prow
bot
added
the
do-not-merge/hold
Replace the hand-rolled tlsMinVersionFromEnv helper in the revision reconciler with the shared knative.dev/pkg/tls package, allowing TLS settings to be configured via TAG_TO_DIGEST_TLS_MIN_VERSION, TAG_TO_DIGEST_TLS_MAX_VERSION, TAG_TO_DIGEST_TLS_CIPHER_SUITES, and TAG_TO_DIGEST_TLS_CURVE_PREFERENCES environment variables. The default minimum version is bumped to TLS 1.3 now that quay.io supports it. Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
Contributor
Author
|
/hold cancel |
knative-prow
bot
removed
the
do-not-merge/hold
linkvt
reviewed
Mar 5, 2026
Contributor
linkvt
left a comment
linkvt
left a comment
There was a problem hiding this comment.
Looks good to me! Bit unsure if we still need the test but on the other hand we make sure that env TLS parsing is configured correctly in the code - so I guess all good 👍
/lgtm
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, Fedosin, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Fedosin
added a commit
to Fedosin/serving
that referenced
this pull request
Mar 20, 2026
… TLS Backport of the following PRs from main to release-1.21: - knative#16424 feat: use knative.dev/pkg/tls for activator TLS configuration - knative#16425 feat: use knative.dev/pkg/tls for queue-proxy TLS configuration - knative#16431 feat: use knative.dev/pkg/tls for reconciler TLS configuration - knative#16458 Update TLS import path to knative.dev/pkg/network/tls Replace hardcoded tls.VersionTLS13 in the activator, queue-proxy, and tag-to-digest resolver with the shared knative.dev/pkg/network/tls package, allowing TLS settings (min/max version, cipher suites, curve preferences) to be configured via environment variables: - ACTIVATOR_TLS_* - QUEUE_PROXY_TLS_* - TAG_TO_DIGEST_TLS_* Add four new keys to the config-deployment ConfigMap (queue-sidecar-tls-min-version, queue-sidecar-tls-max-version, queue-sidecar-tls-cipher-suites, queue-sidecar-tls-curve-preferences) and forward them as QUEUE_PROXY_TLS_* environment variables in makeQueueContainer. The default remains TLS 1.3 when no env var is set. The tag-to-digest resolver default is bumped from TLS 1.2 to TLS 1.3. knative/pkg dependency: knative/pkg#3337 Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
knative-prow bot
pushed a commit
that referenced
this pull request
Mar 20, 2026
… TLS (#16482) Backport of the following PRs from main to release-1.21: - #16424 feat: use knative.dev/pkg/tls for activator TLS configuration - #16425 feat: use knative.dev/pkg/tls for queue-proxy TLS configuration - #16431 feat: use knative.dev/pkg/tls for reconciler TLS configuration - #16458 Update TLS import path to knative.dev/pkg/network/tls Replace hardcoded tls.VersionTLS13 in the activator, queue-proxy, and tag-to-digest resolver with the shared knative.dev/pkg/network/tls package, allowing TLS settings (min/max version, cipher suites, curve preferences) to be configured via environment variables: - ACTIVATOR_TLS_* - QUEUE_PROXY_TLS_* - TAG_TO_DIGEST_TLS_* Add four new keys to the config-deployment ConfigMap (queue-sidecar-tls-min-version, queue-sidecar-tls-max-version, queue-sidecar-tls-cipher-suites, queue-sidecar-tls-curve-preferences) and forward them as QUEUE_PROXY_TLS_* environment variables in makeQueueContainer. The default remains TLS 1.3 when no env var is set. The tag-to-digest resolver default is bumped from TLS 1.2 to TLS 1.3. knative/pkg dependency: knative/pkg#3337 Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Replace the hand-rolled
tlsMinVersionFromEnvhelper in the revision reconciler with the sharedknative.dev/pkg/tlspackage, allowing TLS settings to be configured viaTAG_TO_DIGEST_TLS_MIN_VERSION,TAG_TO_DIGEST_TLS_MAX_VERSION,TAG_TO_DIGEST_TLS_CIPHER_SUITES, andTAG_TO_DIGEST_TLS_CURVE_PREFERENCESenvironment variables. The default minimum version is bumped to TLS 1.3 now that quay.io supports it.Release Note