[release-1.21] feat: use knative.dev/pkg/network/tls for configurable TLS#16482
Merged
knative-prow[bot] merged 1 commit intoknative:release-1.21from Mar 20, 2026
Merged
Conversation
… TLS Backport of the following PRs from main to release-1.21: - knative#16424 feat: use knative.dev/pkg/tls for activator TLS configuration - knative#16425 feat: use knative.dev/pkg/tls for queue-proxy TLS configuration - knative#16431 feat: use knative.dev/pkg/tls for reconciler TLS configuration - knative#16458 Update TLS import path to knative.dev/pkg/network/tls Replace hardcoded tls.VersionTLS13 in the activator, queue-proxy, and tag-to-digest resolver with the shared knative.dev/pkg/network/tls package, allowing TLS settings (min/max version, cipher suites, curve preferences) to be configured via environment variables: - ACTIVATOR_TLS_* - QUEUE_PROXY_TLS_* - TAG_TO_DIGEST_TLS_* Add four new keys to the config-deployment ConfigMap (queue-sidecar-tls-min-version, queue-sidecar-tls-max-version, queue-sidecar-tls-cipher-suites, queue-sidecar-tls-curve-preferences) and forward them as QUEUE_PROXY_TLS_* environment variables in makeQueueContainer. The default remains TLS 1.3 when no env var is set. The tag-to-digest resolver default is bumped from TLS 1.2 to TLS 1.3. knative/pkg dependency: knative/pkg#3337 Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
knative-prow
bot
added
the
size/XL
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.21 #16482 +/- ##
================================================
- Coverage 80.17% 80.16% -0.01%
================================================
Files 216 216
Lines 13440 13449 +9
================================================
+ Hits 10775 10781 +6
- Misses 2301 2303 +2
- Partials 364 365 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/lgtm |
Member
|
/lgtm |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Backport of the following PRs from main to release-1.21:
Replace hardcoded tls.VersionTLS13 in the activator, queue-proxy, and tag-to-digest resolver with the shared knative.dev/pkg/network/tls package, allowing TLS settings (min/max version, cipher suites, curve preferences) to be configured via environment variables:
Add four new keys to the config-deployment ConfigMap (queue-sidecar-tls-min-version, queue-sidecar-tls-max-version, queue-sidecar-tls-cipher-suites, queue-sidecar-tls-curve-preferences) and forward them as QUEUE_PROXY_TLS_* environment variables in makeQueueContainer.
The default remains TLS 1.3 when no env var is set. The tag-to-digest resolver default is bumped from TLS 1.2 to TLS 1.3.
knative/pkg dependency: knative/pkg#3337
Release Note