Fix spelling mistakes in comments, docs, and error strings by Ankitsinghsisodya · Pull Request #16547 · knative/serving

Ankitsinghsisodya · 2026-04-17T09:22:22Z

Changes

Fix ~42 spelling mistakes in source comments, package doc strings, markdown documentation, error/log message strings, and test strings across 37 files
Preserved intentional false positives: ans (variable name for annotations), NotIn (Kubernetes label selector operator), doesnt (part of a fake test URL path), requestor (type name in breaker_test.go)

/kind cleanup

Release Note

NONE

knative-prow · 2026-04-17T09:22:33Z

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copilot

Pull request overview

Housekeeping PR to correct spelling/wording in comments, documentation, and user-/dev-facing strings across the serving codebase (tests, docs, and a few runtime strings).

Changes:

Fix typos in test comments/log strings and a few runtime/help text strings.
Fix typos in markdown/YAML documentation (including configmap inline docs).
Update wording in several injection-gen generated reconciler interface comments.

Reviewed changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
test/ha/workload_test.go	Comment typo fix in HA test.
test/e2e_flags.go	Flag help-text spelling adjustment.
test/e2e/websocket_test.go	Comment typo fix.
test/e2e/logging_test.go	Log message typo fix.
test/e2e-tests.sh	Shell-script comment typo fix.
test/conformance/runtime/readiness_probe_test.go	Comment typo fix.
test/conformance/runtime/cgroup_test.go	Comment typo fix.
test/conformance/api/v1/util.go	Comment typo fix.
test/conformance/api/v1/resources_test.go	Comment typo fix in conformance test.
test/conformance/api/v1/errorcondition_test.go	Test log output typo fix.
test/conformance.go	Comment typo fix in import block.
support/TRIAGE.md	Documentation wording fix.
pkg/reconciler/serverlessservice/serverlessservice_test.go	Comment typo fix.
pkg/reconciler/route/traffic/rollout_test.go	Test error output typo fix.
pkg/reconciler/route/traffic/rollout.go	Comment typo fix.
pkg/reconciler/route/resources/certificate.go	Comment typo fix.
pkg/reconciler/revision/reconcile_resources.go	Comment typo fix.
pkg/reconciler/domainmapping/table_test.go	Test case name typos fixed.
pkg/reconciler/certificate/resources/cert_manager_certificate_test.go	Test case name typo fix.
pkg/queue/sharedmain/main.go	Comment typo fix.
pkg/http/handler/hijack_test.go	Comment typo fix.
pkg/client/injection/reconciler/serving/v1beta1/domainmapping/reconciler.go	Spelling fix inside injection-gen generated comment block.
pkg/client/injection/reconciler/serving/v1/service/reconciler.go	Spelling fix inside injection-gen generated comment block.
pkg/client/injection/reconciler/serving/v1/route/reconciler.go	Spelling fix inside injection-gen generated comment block.
pkg/client/injection/reconciler/serving/v1/revision/reconciler.go	Spelling fix inside injection-gen generated comment block.
pkg/client/injection/reconciler/serving/v1/configuration/reconciler.go	Spelling fix inside injection-gen generated comment block.
pkg/client/injection/reconciler/autoscaling/v1alpha1/podautoscaler/reconciler.go	Spelling fix inside injection-gen generated comment block.
pkg/client/injection/reconciler/autoscaling/v1alpha1/metric/reconciler.go	Spelling fix inside injection-gen generated comment block.
pkg/autoscaler/scaling/metrics.go	Metric description string typo fix.
pkg/autoscaler/scaling/autoscaler_test.go	Align metric description string in tests.
pkg/autoscaler/metrics/stats_scraper_test.go	Test error string wording fix.
pkg/autoscaler/bucket/bucket_test.go	Test failure string typo fix.
pkg/autoscaler/aggregation/bucketing_test.go	Comment typo fix.
pkg/apis/serving/v1/route_lifecycle.go	Comment typo fixes.
pkg/apis/config/features.go	Comment typo fix.
pkg/activator/net/lb_policy_test.go	Comment typo fix.
config/core/configmaps/features.yaml	Fix podinfo path typo in configmap inline docs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

linkvt · 2026-04-17T09:29:07Z

Hi @Ankitsinghsisodya ,

thanks for the PR!
Copilot highlighted a few issues with typo fixes in generated files which we should not modify though

codecov · 2026-04-17T09:37:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.16%. Comparing base (6784d14) to head (3637b18).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16547      +/-   ##
==========================================
- Coverage   80.18%   80.16%   -0.02%     
==========================================
  Files         217      217              
  Lines       13532    13532              
==========================================
- Hits        10850    10848       -2     
- Misses       2319     2320       +1     
- Partials      363      364       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

linkvt · 2026-04-17T09:47:28Z

/ok-to-test

Ankitsinghsisodya · 2026-04-17T10:19:28Z

@linkvt I have done the changes suggested by the co-pilot.

Fix ~42 spelling mistakes across 37 files in source comments, documentation, error/log message strings, and test strings.

- Revert implementers -> implementors in generated reconciler files (these are auto-generated from knative.dev/pkg template) - Update knative.dev/example-checksum after editing features.yaml

linkvt · 2026-04-17T11:12:50Z

Nice, let's see if the tests pass!

/lgtm

dprotaso · 2026-04-17T14:15:13Z

/approve

knative-prow · 2026-04-17T14:15:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitsinghsisodya, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dprotaso]
~~pkg/apis/OWNERS~~ [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

linkvt · 2026-04-17T20:40:11Z

/retest

Uff quite flaky recently

Copilot AI review requested due to automatic review settings April 17, 2026 09:22

knative-prow bot requested review from dsimansk and skonto April 17, 2026 09:22

Copilot started reviewing on behalf of Ankitsinghsisodya April 17, 2026 09:22 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 17, 2026

Ankitsinghsisodya force-pushed the fix/spelling-mistakes branch from 25e8ef1 to 9039707 Compare April 17, 2026 10:18

Ankitsinghsisodya added 2 commits April 17, 2026 16:18

Fix spelling mistakes in comments, docs, and error strings

bf284fe

Fix ~42 spelling mistakes across 37 files in source comments, documentation, error/log message strings, and test strings.

Revert generated reconciler files and update features.yaml checksum

3637b18

- Revert implementers -> implementors in generated reconciler files (these are auto-generated from knative.dev/pkg template) - Update knative.dev/example-checksum after editing features.yaml

Ankitsinghsisodya force-pushed the fix/spelling-mistakes branch from 9039707 to 3637b18 Compare April 17, 2026 10:49

knative-prow bot assigned linkvt Apr 17, 2026

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2026

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2026

knative-prow bot merged commit 5d1d5f8 into knative:main Apr 17, 2026
70 checks passed

Conversation

Ankitsinghsisodya commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

knative-prow bot commented Apr 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

linkvt commented Apr 17, 2026

Uh oh!

codecov bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

linkvt commented Apr 17, 2026

Uh oh!

Ankitsinghsisodya commented Apr 17, 2026

Uh oh!

linkvt commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dprotaso commented Apr 17, 2026

Uh oh!

knative-prow bot commented Apr 17, 2026

Uh oh!

linkvt commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ankitsinghsisodya commented Apr 17, 2026 •

edited

Loading

codecov bot commented Apr 17, 2026 •

edited

Loading

linkvt commented Apr 17, 2026 •

edited

Loading