Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/core/configmaps/features.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ metadata:
app.kubernetes.io/component: controller
app.kubernetes.io/version: devel
annotations:
knative.dev/example-checksum: "9553535b"
knative.dev/example-checksum: "bee75b26"
data:
_example: |-
################################
Expand Down Expand Up @@ -238,7 +238,7 @@ data:
# Enabling will mount a podInfo volume to the queue proxy container.
# The volume will contains an 'annotations' file (from the pod's annotation field).
# The annotations in this file include the Service annotations set by the client creating the service.
# If mounted, the annotations can be accessed by queue proxy extensions at /etc/podinfo/annnotations
# If mounted, the annotations can be accessed by queue proxy extensions at /etc/podinfo/annotations
#
# 1. "enabled": always mount a podInfo volume
# 2. "disabled": never mount a podInfo volume
Expand Down
2 changes: 1 addition & 1 deletion pkg/activator/net/lb_policy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ func TestRandomChoice2(t *testing.T) {
t.Errorf("pt.weight = %d, want: %d", got, want)
}
cb()
// Should return same or the other unsued one.
// Should return same or the other unused one.
_, pt = randomChoice2Policy(context.Background(), podTrackers)
if got, want := pt.getWeight(), wantW; got != want {
t.Errorf("pt.weight = %d, want: %d", got, want)
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/config/features.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const (

// service annotations under features.knative.dev/*
const (
// QueueProxyPodInfoFeatureKey gates mouting of podinfo with the value 'enabled'
// QueueProxyPodInfoFeatureKey gates mounting of podinfo with the value 'enabled'
QueueProxyPodInfoFeatureKey = "features.knative.dev/queueproxy-podinfo"

// AllowHTTPFullDuplexFeatureKey gates the use of http1 full duplex per workload
Expand Down
6 changes: 3 additions & 3 deletions pkg/apis/serving/v1/route_lifecycle.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func (rs *RouteStatus) MarkRevisionTargetTrafficError(reason, msg string) {
}

// MarkConfigurationNotReady marks the RouteConditionAllTrafficAssigned
// condition to indiciate the Revision is not yet ready.
// condition to indicate the Revision is not yet ready.
func (rs *RouteStatus) MarkConfigurationNotReady(name string) {
routeCondSet.Manage(rs).MarkUnknown(RouteConditionAllTrafficAssigned,
"RevisionMissing",
Expand All @@ -140,15 +140,15 @@ func (rs *RouteStatus) MarkConfigurationFailed(name string) {
}

// MarkRevisionNotReady marks the RouteConditionAllTrafficAssigned condition to
// indiciate the Revision is not yet ready.
// indicate the Revision is not yet ready.
func (rs *RouteStatus) MarkRevisionNotReady(name string) {
routeCondSet.Manage(rs).MarkUnknown(RouteConditionAllTrafficAssigned,
"RevisionMissing",
"Revision %q is not yet ready.", name)
}

// MarkRevisionFailed marks the RouteConditionAllTrafficAssigned condition to
// indiciate the Revision has failed.
// indicate the Revision has failed.
func (rs *RouteStatus) MarkRevisionFailed(name string) {
routeCondSet.Manage(rs).MarkFalse(RouteConditionAllTrafficAssigned,
"RevisionMissing",
Expand Down
2 changes: 1 addition & 1 deletion pkg/autoscaler/aggregation/bucketing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ func TestTimedFloat64BucketsWindowAverage(t *testing.T) {
t.Errorf("WindowAverage = %v, want: %v", got, want)
}

// Verify we clear up the data when not receiving data for exact `window` peroid.
// Verify we clear up the data when not receiving data for exact `window` period.
buckets.Record(now.Add(5*time.Second), 10)
if got, want := buckets.WindowAverage(now.Add(5*time.Second)), 10.; got != want {
t.Errorf("WindowAverage = %v, want: %v", got, want)
Expand Down
4 changes: 2 additions & 2 deletions pkg/autoscaler/bucket/bucket_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ func TestIdentity(t *testing.T) {
got, err := Identity()
if err != nil {
if tc.wantErr == "" {
t.Fatal("Unexpect error from Identity(): ", err)
t.Fatal("Unexpected error from Identity(): ", err)
}
if got := err.Error(); got != tc.wantErr {
t.Errorf("got := %v, want = %v", got, tc.wantErr)
Expand All @@ -146,7 +146,7 @@ func TestIdentity(t *testing.T) {
func TestExtractPodNameAndIP(t *testing.T) {
gotName, gotIP, err := ExtractPodNameAndIP("as_1.2.3.4")
if err != nil {
t.Fatal("Unexpect error from Identity(): ", err)
t.Fatal("Unexpected error from Identity(): ", err)
}
if wantName := "as"; gotName != wantName {
t.Errorf("got := %v, want = %v", gotName, wantName)
Expand Down
2 changes: 1 addition & 1 deletion pkg/autoscaler/metrics/stats_scraper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ func TestPodDirectScrapeSomeFailWithNonMeshError(t *testing.T) {
mightBeMesh: true,
}
nonMeshErr := scrapeError{
error: errors.New("cant mesh with this"),
error: errors.New("can't mesh with this"),
mightBeMesh: false,
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/autoscaler/scaling/autoscaler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@ func panicMetric(panic bool) metricdata.Metrics {
}
return metricdata.Metrics{
Name: "kn.revision.panic.mode",
Description: "If greater tha 0 the autoscaler is in panic mode",
Description: "If greater than 0 the autoscaler is in panic mode",
Data: metricdata.Gauge[int64]{
DataPoints: []metricdata.DataPoint[int64]{{
Value: int64(val),
Expand Down
2 changes: 1 addition & 1 deletion pkg/autoscaler/scaling/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func newMetrics(mp metric.MeterProvider, scalingMetric string, attrs attribute.S

m.panicMode = must(meter.Int64ObservableGauge(
"kn.revision.panic.mode",
metric.WithDescription("If greater tha 0 the autoscaler is in panic mode"),
metric.WithDescription("If greater than 0 the autoscaler is in panic mode"),
))

switch scalingMetric {
Expand Down
2 changes: 1 addition & 1 deletion pkg/http/handler/hijack_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func TestHijackTrackerConnectionHijackedTimeout(t *testing.T) {
}()

<-drainStarted
// note: this is defered to unblock the go-routine
// note: this is deferred to unblock the go-routine
// to clean up the test
defer close(handlerWait)

Expand Down
2 changes: 1 addition & 1 deletion pkg/queue/sharedmain/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ type Env struct {
ServingPodIP string `split_words:"true" required:"true"`
}

// Defaults provides Options (QP Extensions) with the default bahaviour of QP
// Defaults provides Options (QP Extensions) with the default behaviour of QP
// Some attributes of Defaults may be modified by Options
// Modifying Defaults mutates the behavior of QP
type Defaults struct {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ func TestGetReadyCondition(t *testing.T) {
Message: "not ready",
},
}, {
name: "unknow",
name: "unknown",
cmCertificate: makeTestCertificate(cmmeta.ConditionUnknown, cmv1.CertificateConditionReady, "unknown", "unknown"),
want: &cmv1.CertificateCondition{
Type: cmv1.CertificateConditionReady,
Expand Down
4 changes: 2 additions & 2 deletions pkg/reconciler/domainmapping/table_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ func TestReconcile(t *testing.T) {
Eventf(corev1.EventTypeNormal, "Created", "Created Ingress %q", "first-reconcile.com"),
},
}, {
Name: "first reconcile, cant claim domain",
Name: "first reconcile, can't claim domain",
Key: "default/first-reconcile.com",
Objects: []runtime.Object{
domainMapping("default", "first-reconcile.com", withRef("default", "target")),
Expand Down Expand Up @@ -833,7 +833,7 @@ func TestReconcileAutocreateClaimsDisabled(t *testing.T) {
Eventf(corev1.EventTypeNormal, "Created", "Created Ingress %q", "first-reconcile.com"),
},
}, {
Name: "first reconcile, claim exists but isnt owned",
Name: "first reconcile, claim exists but isn't owned",
Key: "default/first-reconcile.com",
Objects: []runtime.Object{
domainMapping("default", "first-reconcile.com", withRef("default", "target")),
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/revision/reconcile_resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ func (c *Reconciler) reconcilePA(ctx context.Context, rev *v1.Revision) error {
logger.Debugf("Observed PA Status=%#v", pa.Status)
rev.Status.PropagateAutoscalerStatus(&pa.Status)

// Perhaps tha PA spec changed underneath ourselves?
// Perhaps the PA spec changed underneath ourselves?
// We no longer require immutability, so need to reconcile PA each time.
tmpl := resources.MakePA(rev, deployment)
logger.Debugf("Desired PASpec: %#v", tmpl.Spec)
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/route/resources/certificate.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ func MakeClusterLocalCertificate(route *v1.Route, tag string, domains sets.Set[s
}
}

// certNameFromRouteAndTag returns a possibly shortended certName as
// certNameFromRouteAndTag returns a possibly shortened certName as
// k8s supports cert name only up to 63 chars and so is constructed as route-[UID]-[tag digest]
// where route-[UID] will take 42 characters and leaves 20 characters for tag digest (need to include `-`).
// We use https://golang.org/pkg/hash/adler32/#Checksum to compute the digest which returns a uint32.
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/route/traffic/rollout.go
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ func stepRevisions(goal *ConfigurationRollout, nowTS int64) {
}

// stepConfig takes previous and goal configuration shapes and returns a new
// config rollout, after computing the percetage allocations.
// config rollout, after computing the percentage allocations.
func stepConfig(goal, prev *ConfigurationRollout, nowTS int64, logger *zap.SugaredLogger) *ConfigurationRollout {
pc := len(prev.Revisions)
ret := &ConfigurationRollout{
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/route/traffic/rollout_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1249,7 +1249,7 @@ func TestAdjustPercentage(t *testing.T) {
logger := TestLogger(t)
adjustPercentage(tc.goal, tc.prev, logger)
if got, want := tc.prev.Revisions, tc.want; !cmp.Equal(got, want, cmpopts.EquateEmpty()) {
t.Errorf("Rollout Mistmatch(-want,+got):\n%s", cmp.Diff(want, got))
t.Errorf("Rollout Mismatch(-want,+got):\n%s", cmp.Diff(want, got))
}
})
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/serverlessservice/serverlessservice_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ func TestReconcile(t *testing.T) {
withFilteredPorts(networking.BackendHTTPPort)),
}},
}, {
// This is the case for once we are proxying for unsufficient burst capacity.
// This is the case for once we are proxying for insufficient burst capacity.
// It should be a no-op.
Name: "steady switch to proxy mode with endpoints",
Key: "steady/to-proxy",
Expand Down
4 changes: 2 additions & 2 deletions support/TRIAGE.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ At the end of reading an issue, you should do one of the following:
1. Move it to the correct repo (for example, Istio-specific questions should
probably go to `net-istio`). In some cases, you may need to create a new
issue in the new repo and link / copy the current issue. If you do this, be
sure to `@mention` the requestor and others on the old issue, and then
sure to `@mention` the requester and others on the old issue, and then
`/close` the issue is serving with a link to the other repo.

1. If it's not clear what the problem or issue is, add a note for the requestor
1. If it's not clear what the problem or issue is, add a note for the requester
(or occasionally some other user on the thread), make sure that there is a
reasonable `/kind` on the issue and mark it as `/triage needs-user-input` so
that it's off the list for a few days. If a `needs-user-input` issue persists
Expand Down
2 changes: 1 addition & 1 deletion test/conformance.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
"testing"

// For our e2e testing, we want this linked first so that our
// systen namespace environment variable is defaulted prior to
// system namespace environment variable is defaulted prior to
// logstream initialization.
_ "knative.dev/serving/test/defaultsystem"

Expand Down
2 changes: 1 addition & 1 deletion test/conformance/api/v1/errorcondition_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func TestContainerExitingMsg(t *testing.T) {
t.Log("When the containers keep crashing, the Revision should have error status.")
err = v1test.CheckRevisionState(clients.ServingClient, names.Revision, func(r *v1.Revision) (bool, error) {
cond := r.Status.GetCondition(v1.RevisionConditionReady)
t.Logf("Revsion %s Ready status = %v", names.Revision, cond)
t.Logf("Revision %s Ready status = %v", names.Revision, cond)
if cond != nil {
if cond.Reason != "" && cond.Message != "" {
return true, nil
Expand Down
2 changes: 1 addition & 1 deletion test/conformance/api/v1/resources_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func TestCustomResourcesLimits(t *testing.T) {
}

// ExceedingMemoryLimitSize defaults to 500.
// Allows override the memory usage to get a non-200 resposne because the serverless platform
// Allows override the memory usage to get a non-200 response because the serverless platform
Comment thread
Ankitsinghsisodya marked this conversation as resolved.
// MAY automatically adjust the resource limits.
// See https://github.com/knative/specs/blob/main/specs/serving/runtime-contract.md#memory-and-cpu-limits
exceedingMemory := test.ServingFlags.ExceedingMemoryLimitSize
Expand Down
2 changes: 1 addition & 1 deletion test/conformance/api/v1/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ func validateK8sServiceAnnotations(t *testing.T, clients *test.Clients, names te
}

func validateReleaseServiceShape(objs *v1test.ResourceObjects) error {
// Traffic should be routed to the lastest created revision.
// Traffic should be routed to the latest created revision.
if got, want := objs.Service.Status.Traffic[0].RevisionName, objs.Config.Status.LatestReadyRevisionName; got != want {
return fmt.Errorf("Status.Traffic[0].RevisionsName = %s, want: %s", got, want)
}
Expand Down
2 changes: 1 addition & 1 deletion test/conformance/runtime/cgroup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func isCgroupsV2(mounts []*types.Mount) (bool, error) {
}

// TestMustHaveCgroupConfigured verifies that the Linux cgroups are configured based on the specified
// resource limits and requests as delared by "MUST" in the runtime-contract.
// resource limits and requests as declared by "MUST" in the runtime-contract.
func TestMustHaveCgroupConfigured(t *testing.T) {
t.Parallel()
clients := test.Setup(t)
Expand Down
2 changes: 1 addition & 1 deletion test/conformance/runtime/readiness_probe_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const (
// - Readiness.PeriodSeconds=10
// - Readiness.FailureThreshold=3
//
// Thus it takes at a mininum 30 seconds for the Pod to become
// Thus it takes at a minimum 30 seconds for the Pod to become
// unready. To account for this we bump max propagation time
readinessPropagationTime = time.Minute
readinessPath = "/healthz/readiness"
Expand Down
2 changes: 1 addition & 1 deletion test/e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ kubectl replace cm "config-gc" -n "${SYSTEM_NAMESPACE}" -f "${TMP_DIR}"/config-g
# Note that we use a very high -parallel because each ksvc is run as its own
# sub-test. If this is not larger than the maximum scale tested then the test
# simply cannot pass.
# TODO - Renable once we get this reliably passing on GKE 1.21
# TODO - Re-enable once we get this reliably passing on GKE 1.21
# go_test_e2e -timeout=20m -parallel=300 ./test/scale "${E2E_TEST_FLAGS[@]}" || failed=1

# Run HPA tests
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/logging_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func TestRequestLogs(t *testing.T) {
t.Fatal("Got error waiting for normal request logs:", err)
}
} else {
t.Log("Skipping verifing request logs because they are not enabled")
t.Log("Skipping verifying request logs because they are not enabled")
}

// Only check probe request logs if the feature is enabled in config-observability.
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/websocket_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const (
)

// Connects to a WebSocket target and executes `numReqs` requests.
// Collects the answer frequences and returns them.
// Collects the answer frequencies and returns them.
// Returns nil map and error if any of the requests fails.
func webSocketResponseFreqs(t *testing.T, clients *test.Clients, url string, numReqs int) (map[string]int, error) {
t.Helper()
Expand Down
2 changes: 1 addition & 1 deletion test/e2e_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func initializeServingFlags() *ServingEnvironmentFlags {

flag.IntVar(&f.ExceedingMemoryLimitSize, "exceeding-memory-limit-size", 500,
"Set this flag to the MB of memory consumed by your service in resource limit tests. "+
"You service is set with 300 MB memory limit and shoud return a non-200 response when consuming such amount of memory.")
"Your service is set with 300 MB memory limit and should return a non-200 response when consuming such amount of memory.")

flag.StringVar(&f.RequestHeaders, "request-headers", "",
"Set this flag to add extra HTTP request headers sent to the testing deployed KServices. "+
Expand Down
2 changes: 1 addition & 1 deletion test/ha/workload_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func deleteUserPods(t *testing.T, ctx context.Context, clients *test.Clients, se
}

if err := pkgTest.WaitForPodState(ctx, clients.KubeClient, func(p *corev1.Pod) (bool, error) {
// Always return false. We're oly interested in the error which indicates pod deletion or timeout.
// Always return false. We're only interested in the error which indicates pod deletion or timeout.
t.Logf("%q still not deleted - %s", p.Name, time.Now().String())
return false, nil
}, pod.Name, pod.Namespace); err != nil {
Expand Down
Loading