docs: update HTTP links to HTTPS in comments and docs#16551
docs: update HTTP links to HTTPS in comments and docs#16551knative-prow[bot] merged 4 commits intoknative:mainfrom
Conversation
Replace insecure HTTP reference links with HTTPS equivalents across source comments, CRD YAML descriptions, configmap comments, and generated API docs: - pkg/apis/serving/v1/revision_types.go: upgrade bit.ly ref links in ContainerStatuses and InitContainerStatuses comments - pkg/autoscaler/aggregation/max/window.go: upgrade Wayback Machine link in ascending minima algorithm comment - config/core/300-resources/revision.yaml: upgrade bit.ly ref links in containerStatuses and initContainerStatuses field descriptions - config/core/configmaps/autoscaler.yaml: upgrade bit.ly link in activator-capacity algorithm comment - docs/serving-api.md: upgrade bit.ly href links in generated API reference for RevisionStatus fields - DEVELOPMENT.md: upgrade Google Cloud Console link /kind cleanup
knative-prow
bot
added
kind/cleanup
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
bot
added
the
needs-ok-to-test
There was a problem hiding this comment.
Pull request overview
Updates documentation/comment reference links from HTTP to HTTPS to avoid insecure link targets across code comments, CRD YAML, configmaps, and generated API docs.
Changes:
- Replaced HTTP links with HTTPS in Go source comments and Markdown docs.
- Updated CRD YAML field descriptions and configmap comments to use HTTPS links.
- Updated generated API reference HTML links to HTTPS.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/autoscaler/aggregation/max/window.go | Updates Wayback Machine reference link to HTTPS in algorithm comment. |
| pkg/apis/serving/v1/revision_types.go | Updates image digest reference link to HTTPS in RevisionStatus field comments. |
| config/core/300-resources/revision.yaml | Updates image digest reference link to HTTPS in CRD schema descriptions. |
| config/core/configmaps/autoscaler.yaml | Updates autoscaler algorithm reference link to HTTPS in config comment. |
| docs/serving-api.md | Updates generated API reference links to HTTPS for RevisionStatus fields. |
| DEVELOPMENT.md | Updates GCP console link to HTTPS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1549,7 +1549,7 @@ spec: | |||
| The digests are resolved during the creation of Revision. | |||
| ContainerStatuses holds the container name and image digests | |||
There was a problem hiding this comment.
In the initContainerStatuses schema description, the text still says "ContainerStatuses holds..." which is inaccurate for initContainerStatuses. Update the description to refer to InitContainerStatuses (ideally by regenerating this CRD from the Go types after fixing the source comment).
| ContainerStatuses holds the container name and image digests | |
| InitContainerStatuses holds the container name and image digests |
| ContainerStatuses holds the container name and image digests | ||
| for both serving and non serving containers. |
There was a problem hiding this comment.
The initContainerStatuses API reference text still says "ContainerStatuses holds..." which is misleading for this field. Please update the underlying Go type comment and regenerate the API reference docs so this reads correctly for initContainerStatuses.
| ContainerStatuses holds the container name and image digests | |
| for both serving and non serving containers. | |
| InitContainerStatuses holds the container name and image digests | |
| for init containers. |
| @@ -154,7 +154,7 @@ type RevisionStatus struct { | |||
| // The digests are resolved during the creation of Revision. | |||
| // ContainerStatuses holds the container name and image digests | |||
There was a problem hiding this comment.
The doc string for InitContainerStatuses still says "ContainerStatuses holds..." which is misleading for this field. Please update this sentence to refer to InitContainerStatuses (or rephrase to avoid repeating the field name) so the API comment matches the actual field.
| // ContainerStatuses holds the container name and image digests | |
| // InitContainerStatuses holds the container name and image digests |
knative-prow
bot
added
size/XXL
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16551 +/- ##
==========================================
- Coverage 80.18% 80.15% -0.03%
==========================================
Files 217 217
Lines 13532 13532
==========================================
- Hits 10850 10846 -4
+ Misses 2319 2318 -1
- Partials 363 368 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
knative-prow
bot
added
size/S
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitsinghsisodya, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
knative-prow
bot
added
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Closes #16552
Replace insecure HTTP reference links with HTTPS equivalents across source comments, CRD YAML descriptions, configmap comments, and generated API docs:
/kind cleanup