Skip to content

docs: update HTTP links to HTTPS in comments and docs #16551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 4 commits into from
Apr 17, 2026
Merged

docs: update HTTP links to HTTPS in comments and docs #16551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a490708
docs: update HTTP links to HTTPS in comments and docs
Ankitsinghsisodya Apr 17, 2026
dc6ad39
running codegen
Ankitsinghsisodya Apr 17, 2026
5fc4456
removing wrong file
Ankitsinghsisodya Apr 17, 2026
b6bf886
Remove core.md from PR tracking (keep file locally)
Ankitsinghsisodya Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ kubectl -n knative-serving logs $(kubectl -n knative-serving get pods -l app=con

If you're using a GCP project to host your Kubernetes cluster, it's good to
check the
[Discovery & load balancing](http://console.developers.google.com/kubernetes/discovery)
[Discovery & load balancing](https://console.developers.google.com/kubernetes/discovery)
page to ensure that all services are up and running (and not blocked by a quota
issue, for example).

Expand Down
4 changes: 2 additions & 2 deletions config/core/300-resources/revision.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1528,7 +1528,7 @@ spec:
The digests are resolved during the creation of Revision.
ContainerStatuses holds the container name and image digests
for both serving and non serving containers.
ref: http://bit.ly/image-digests
ref: https://bit.ly/image-digests
type: array
items:
description: ContainerStatus holds the information of container name and image digest value
Expand All @@ -1549,7 +1549,7 @@ spec:
The digests are resolved during the creation of Revision.
ContainerStatuses holds the container name and image digests
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the initContainerStatuses schema description, the text still says "ContainerStatuses holds..." which is inaccurate for initContainerStatuses. Update the description to refer to InitContainerStatuses (ideally by regenerating this CRD from the Go types after fixing the source comment).

Suggested change
ContainerStatuses holds the container name and image digests
InitContainerStatuses holds the container name and image digests

Copilot uses AI. Check for mistakes.
for both serving and non serving containers.
ref: http://bit.ly/image-digests
ref: https://bit.ly/image-digests
type: array
items:
description: ContainerStatus holds the information of container name and image digest value
Expand Down
4 changes: 2 additions & 2 deletions config/core/configmaps/autoscaler.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ metadata:
app.kubernetes.io/name: knative-serving
app.kubernetes.io/version: devel
annotations:
knative.dev/example-checksum: "47c2487f"
knative.dev/example-checksum: "c727b3e8"
data:
_example: |
################################
Expand Down Expand Up @@ -172,7 +172,7 @@ data:
# The `unit` is one concurrent request proxied by the activator.
# activator-capacity must be at least 1.
# This value is used for computation of the Activator subset size.
# See the algorithm here: http://bit.ly/38XiCZ3.
# See the algorithm here: https://bit.ly/38XiCZ3.
# TODO(vagababov): tune after actual benchmarking.
activator-capacity: "100.0"

Expand Down
4 changes: 2 additions & 2 deletions docs/serving-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1476,7 +1476,7 @@ to their respective digests and their container name.
The digests are resolved during the creation of Revision.
ContainerStatuses holds the container name and image digests
for both serving and non serving containers.
ref: <a href="http://bit.ly/image-digests">http://bit.ly/image-digests</a></p>
ref: <a href="https://bit.ly/image-digests">https://bit.ly/image-digests</a></p>
</td>
</tr>
<tr>
Expand All @@ -1495,7 +1495,7 @@ to their respective digests and their container name.
The digests are resolved during the creation of Revision.
ContainerStatuses holds the container name and image digests
for both serving and non serving containers.
Comment on lines 1496 to 1497
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initContainerStatuses API reference text still says "ContainerStatuses holds..." which is misleading for this field. Please update the underlying Go type comment and regenerate the API reference docs so this reads correctly for initContainerStatuses.

Suggested change
ContainerStatuses holds the container name and image digests
for both serving and non serving containers.
InitContainerStatuses holds the container name and image digests
for init containers.

Copilot uses AI. Check for mistakes.
ref: <a href="http://bit.ly/image-digests">http://bit.ly/image-digests</a></p>
ref: <a href="https://bit.ly/image-digests">https://bit.ly/image-digests</a></p>
</td>
</tr>
<tr>
Expand Down
4 changes: 2 additions & 2 deletions pkg/apis/serving/v1/revision_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ type RevisionStatus struct {
// The digests are resolved during the creation of Revision.
// ContainerStatuses holds the container name and image digests
// for both serving and non serving containers.
// ref: http://bit.ly/image-digests
// ref: https://bit.ly/image-digests
// +optional
ContainerStatuses []ContainerStatus `json:"containerStatuses,omitempty"`

Expand All @@ -154,7 +154,7 @@ type RevisionStatus struct {
// The digests are resolved during the creation of Revision.
// ContainerStatuses holds the container name and image digests
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc string for InitContainerStatuses still says "ContainerStatuses holds..." which is misleading for this field. Please update this sentence to refer to InitContainerStatuses (or rephrase to avoid repeating the field name) so the API comment matches the actual field.

Suggested change
// ContainerStatuses holds the container name and image digests
// InitContainerStatuses holds the container name and image digests

Copilot uses AI. Check for mistakes.
// for both serving and non serving containers.
// ref: http://bit.ly/image-digests
// ref: https://bit.ly/image-digests
// +optional
InitContainerStatuses []ContainerStatus `json:"initContainerStatuses,omitempty"`

Expand Down
2 changes: 1 addition & 1 deletion pkg/autoscaler/aggregation/max/window.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ type entry struct {
}

// window is a circular buffer which keeps track of the maximum value observed in a particular time.
// Based on the "ascending minima algorithm" (http://web.archive.org/web/20120805114719/http://home.tiac.net/~cri/2001/slidingmin.html).
// Based on the "ascending minima algorithm" (https://web.archive.org/web/20120805114719/http://home.tiac.net/~cri/2001/slidingmin.html).
type window struct {
maxima []entry
first, length int
Expand Down
Loading