Skip to content

Move PodSpec DryRun to enabled by default#8582

Merged
knative-prow-robot merged 9 commits intoknative:masterfrom
whaught:default-dryrun
Jul 15, 2020
Merged

Move PodSpec DryRun to enabled by default#8582
knative-prow-robot merged 9 commits intoknative:masterfrom
whaught:default-dryrun

Conversation

@whaught
Copy link
Copy Markdown
Contributor

@whaught whaught commented Jul 8, 2020 •
edited
Loading

Issue #8077

Proposed Changes

  • Moves the default value of podspec-dryrun to 'enabled'

Release Note

Moves the PodSpec DryRun feature flag from Allowed to Enabled. This will now be the default behavior unless overridden.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2020
knative-prow-robot
knative-prow-robot reviewed Jul 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whaught: 0 warnings.

Details

In response to this:

Issue ##8077

Proposed Changes

  • Moves the default value of podspec-dryrun to 'enabled'

Release Note

Moves the PodSpec DryRun feature flag from Allowed to Enabled. This will now be the default behavior unless overridden.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Jul 8, 2020
@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented Jul 8, 2020

/assign @dprotaso

@vagababov
Copy link
Copy Markdown
Contributor

vagababov commented Jul 8, 2020

🚀

@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented Jul 8, 2020

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2020
@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented Jul 9, 2020

/retest

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 9, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Jul 9, 2020
dprotaso
dprotaso reviewed Jul 9, 2020
View reviewed changes
Comment thread config/core/configmaps/features.yaml Outdated
@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented Jul 9, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2020
@whaught whaught mentioned this pull request Jul 9, 2020
Merged
@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented Jul 10, 2020

@googlebot cla should be fine

@whaught whaught mentioned this pull request Jul 10, 2020
Merged
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2020
@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented Jul 14, 2020

/assign @mattmoor

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jul 14, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/autoscaler/metrics.TestMetricCollectorScraper

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Jul 15, 2020

/retest

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Jul 15, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@vagababov
Copy link
Copy Markdown
Contributor

vagababov commented Jul 15, 2020

🚢 🚀

@knative-prow-robot knative-prow-robot merged commit f77cfe6 into knative:master Jul 15, 2020
@whaught whaught deleted the default-dryrun branch July 31, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso dprotaso left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@evankanderson evankanderson Awaiting requested review from evankanderson

@vagababov vagababov Awaiting requested review from vagababov

Assignees

@dprotaso dprotaso

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@whaught @vagababov @knative-test-reporter-robot @dprotaso @knative-prow-robot @mattmoor @googlebot