Skip to content

Ensure all yaml checksums are quoted#8590

Merged
knative-prow-robot merged 2 commits intoknative:masterfrom
whaught:checksum-quote
Jul 11, 2020
Merged

Ensure all yaml checksums are quoted#8590
knative-prow-robot merged 2 commits intoknative:masterfrom
whaught:checksum-quote

Conversation

@whaught
Copy link
Copy Markdown
Contributor

@whaught whaught commented Jul 9, 2020

Proposed Changes

  • If you win the hashcode lottery and get a checksum that is all numeric, this parses as an int instead of a string and fails.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 9, 2020
@vagababov
Copy link
Copy Markdown
Contributor

You probably want to actually change the generator in pkg to emit this as such (though I think it's already a sting node).

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Jul 9, 2020

@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented Jul 9, 2020

For pkg: knative/pkg#1472

@vagababov
Copy link
Copy Markdown
Contributor

Abandon this one? :)

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 10, 2020
@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented Jul 10, 2020

Abandon this one? :)

These aren't dynamically generated by pkg or anything. I think we still want to fix the formatting in the dependant repos so this doesn't proliferate from copy/pasting

@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Jul 10, 2020
@vagababov
Copy link
Copy Markdown
Contributor

did you generate those with update-codegen ?

@dprotaso
Copy link
Copy Markdown
Member

yeah update codgen updates the checksums

@whaught whaught force-pushed the checksum-quote branch 2 times, most recently from 877d879 to 21ccd01 Compare July 10, 2020 19:41
@vagababov
Copy link
Copy Markdown
Contributor

yeah update codgen updates the checksums

I know :) I wanted to make sure here it's done this way vs original manual quotations
/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2020
@knative-test-reporter-robot
Copy link
Copy Markdown

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/autoscaler/metrics.TestMetricCollectorScraper

@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented Jul 11, 2020

/test pull-knative-serving-unit-tests

@knative-prow-robot knative-prow-robot merged commit 2ab08ed into knative:master Jul 11, 2020
@whaught whaught deleted the checksum-quote branch July 14, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants