🎁 Buoy will float to branch for submodules other then root#37
Conversation
|
Skipping CI for Draft Pull Request. |
knative-prow
Bot
added
the
do-not-merge/work-in-progress
![knative-prow[bot]](https://avatars.githubusercontent.com/in/183726?s=60&v=4){kind=small}
There was a problem hiding this comment.
@cardil: 0 warnings.
Details
In response to this:
Which issue(s) this PR fixes:
Fixes #36
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
knative-prow
Bot
added
approved
cardil
changed the title
knative-prow
Bot
removed
the
do-not-merge/work-in-progress
|
/cc @dsimansk I think this is it. Please, take a look. |
dsimansk
left a comment
dsimansk
left a comment
There was a problem hiding this comment.
Would you mind capturing a note in README.md and also adding a bit of context to the float cmd help message, pls?
|
Otherwise works well in a few tries I've done on main Serving and plugins repos. It really does what we need with recognizing submodule. :) |
| "Any - v0.2 - with submodule": { | ||
| repo: submoduleRepo, | ||
| version: semver.MustParse("0.2.0"), | ||
| want: "ref@release-0.2", |
There was a problem hiding this comment.
I think this should be ref@sub/release-0.2 no? is this not a tag? perhaps this is a branch and I don't fully understand what the goal is.
There was a problem hiding this comment.
We thought to go for the branches for submodules. Otherwise, we would need to add additional Git tags to the repo like: sub/v0.2.0.
In fact, in that case we wouldn't need to adjust the buoy, as the ref@v0.2.0 will just work, if those additional tags were added to the repo.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Which issue(s) this PR fixes:
Fixes #36