Skip to content

fix ssr_gc_function signature mismatch in ssr gain control - #226

Merged
fabiangreffrath merged 2 commits into
knik0:masterfrom
netliomax25-code:ssr-gc-function-signature
Jul 5, 2026
Merged

fix ssr_gc_function signature mismatch in ssr gain control#226
fabiangreffrath merged 2 commits into
knik0:masterfrom
netliomax25-code:ssr-gc-function-signature

Conversation

@netliomax25-code

Copy link
Copy Markdown
Contributor
  1. ssr_gc_function is declared in ssr.h with five parameters but defined in ssr.c with a sixth band parameter, and the two calls in ssr_gain_control() disagree: the long-window path passes six arguments while the eight-short path passes five.
  2. with SSR_DEC enabled this does not compile (conflicting types for ssr_gc_function, and too many arguments at the long-window call), and band is never read in the function body.
  3. ssr_decode() also calls ssr_ipqf() without including ssr_ipqf.h, a second compile error on the same path.

Removed the unused band parameter so the definition and both calls match the declaration, and added the missing ssr_ipqf.h include. ssr.c is compiled only under SSR_DEC, so the default build is unchanged.

Comment thread libfaad/ssr.c
@fabiangreffrath
fabiangreffrath merged commit fd9e00e into knik0:master Jul 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants