feat: add FocusChin to guide toolbar v2 with dedicated controls for focus state#920
Conversation
🦋 Changeset detectedLatest commit: 91adc51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
d2c0d41 to
dfec9cc
Compare
1f8dc0a to
fc8a78d
Compare
dfec9cc to
d5f8a08
Compare
fc8a78d to
fa84159
Compare
6f81692 to
c981a12
Compare
fa84159 to
7644f64
Compare
86f94fb to
e1b183b
Compare
b1c3441 to
a8f7cae
Compare
e1b183b to
9da9e15
Compare
9da9e15 to
a5f1892
Compare
a8f7cae to
658c1c9
Compare
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| </Box> | ||
|
|
||
| {/* Focus chin with dedicated controls */} | ||
| <FocusChin guides={guides} /> |
There was a problem hiding this comment.
Focus navigation uses filtered guide subset
Low Severity
FocusChin receives the already filtered guides list from V2.tsx, then computes previous/next from that subset. If focusedGuideKeys points to a guide no longer in the active filter (for example after live eligibility changes), currentKey is missing from selectableGuides, so both arrow controls become no-ops.
Additional Locations (2)
There was a problem hiding this comment.
Not an issue as we now unfocus if/when the currently focused guide becomes not visible in the new filtered list.
connorlindsey
left a comment
There was a problem hiding this comment.
Looks cool! Could also just be via hotkey like arrow keys to cycle through and auto-focus guides
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
- Coverage 64.61% 63.66% -0.96%
==========================================
Files 207 208 +1
Lines 9711 9882 +171
Branches 1254 1254
==========================================
+ Hits 6275 6291 +16
- Misses 3411 3566 +155
Partials 25 25
|



Description
Adds a "FocusChin" component to the guide toolbar v2, which shows up when currently focused on a guide and has dedicated controls to move to the next or previous guide, or quit out of focus altogether.
This is more of an experiment based on this feedback, and will need inputs from Sam and Krisna.
Screenshots or videos
CleanShot.2026-03-31.at.15.27.56.mp4