chore: change filter options to All|Active|Eligible in guides toolbar v2#925
Closed
thomaswhyyou wants to merge 4 commits intothomas-kno-12204-toolbar-beta-qa-and-feedback-items-6from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: c98ae33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Mar 31, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 31, 2026
thomaswhyyou
changed the title
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
thomaswhyyou
requested review from
andy-knock,
connorlindsey and
kylemcd
and removed request for
a team
thomaswhyyou
force-pushed
the
thomas-kno-12204-toolbar-beta-qa-and-feedback-items-7
branch
from
e2b6fc4 to
c98ae33
Compare
thomaswhyyou
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## thomas-kno-12204-toolbar-beta-qa-and-feedback-items-6 #925 +/- ##
=========================================================================================
- Coverage 63.66% 63.46% -0.21%
=========================================================================================
Files 208 208
Lines 9882 9918 +36
Branches 1254 1254
=========================================================================================
+ Hits 6291 6294 +3
- Misses 3566 3599 +33
Partials 25 25
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a toggle to filter only active guides in the guide toolbar v2, per this feedback.
When ON, we change the list filter to say "All active" instead of "All guides".
Screenshots or videos
CleanShot.2026-03-31.at.15.54.49.mp4