fix: harden callgraph.go - #178
Merged
Merged
Conversation
Robustness/correctness hardening. See PR description for the fix list. Base af5e709. RED->GREEN tests included.
gadievron
requested review from
dgeyshis,
shahar-davidson and
sounil
as code owners
July 19, 2026 09:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Robustness/correctness hardening for
callgraph.go.Fixes in this PR (3)
Tests
Each fix ships a RED→GREEN regression test (added under
tests/). All fixes were adversarially reviewed and the full set verified against the base with no new static-analysis findings (ruff/bandit/semgrep/CodeQL/go vet).Base / scope
Branched from
master(baseaf5e709). This PR touches only the files listed above and is independently mergeable (no file overlap with the sibling hardening PRs).