ci: single test:acceptance aggregate so CI and release cannot drift (#81) - #97
Merged
Conversation
release-suites) The release tag gate omitted test:github-first, test:profiles, and test:regression-judge (and CI omitted test:github-first), so a release could pass while the profile-composition and judge contracts regressed. Introduce a package.json `test:acceptance` aggregate listing every required suite; both ci.yml and release.yml now delegate to it — one source of truth, no drift. A new workflow test asserts test:acceptance covers every required suite and that both workflows call it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwyFyRC6pepaK6DuMK7YeT
huiyu
added a commit
that referenced
this pull request
Aug 25, 2026
…docs to the test:acceptance aggregate - readiness doc: the "Residual risks" section was stale (missing R5, pre-campaign-3 descriptions, and a stale "CI runs five / release runs three" line contradicting #97). Rewritten as R1–R5 plus explicit post-3.0 deferrals (#47, the PRD→registry→ scope runtime harness), and the CI/release line now states both use test:acceptance. - docs/testing.md + docs/testing_cn.md: the "Fast Deterministic Checks" block listed a stale subset of suites. Replaced with the single `npm run test:acceptance` aggregate (matching the doc's own "don't copy directory listings" philosophy), noting the binary-gated live tests skip when the model binary is absent. CN twin updated in the same commit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwyFyRC6pepaK6DuMK7YeT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Campaign-3 fix #2 — release-workflow suite coverage (from the third review pass).
The release tag gate ran project-context/registry/cross-review but not
test:github-first,test:profiles, ortest:regression-judge— so a release could pass while the profile-composition and judge contracts regressed. (CI also omittedtest:github-first.)Fix
package.jsontest:acceptanceaggregate lists every required suite.ci.ymlandrelease.ymlnow delegate tonpm run test:acceptance— one source of truth, no drift.test:acceptancecovers every required suite and that both workflows call it (so the anti-drift guarantee is itself tested).Verification
npm run test:acceptancegreen end-to-end (exit 0), including the three previously-omitted suites.🤖 Generated with Claude Code