Conversation
3mcd
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way the
initialData/viewDatais read/serialized.Before, it was
JSON.stringify'd on an attribute of a script at the bottom. Then that attribute would be read with JSON.parse.Now, I just set the contents of the HTML directly using
dangerouslySetInnerHTML.Why?
Using base
JSON.stringifyin React leads to data that looks likeAll those
"s are"s. We are using 5 characters to encode what should be one, so wasteful! Especially when it's the most common character in JSON!By setting the contents of the script to the initial data using
dangerouslySetInnerHTMLinstead, like so (I stole this way of doing it from Next)we save quite a lot of space.
Here are some numbers for comparison.
Very intersting that Cursor shows so little change, wonder why!
As you can see, we make quite some saving for literally no cost. The only downside is that the initial data is now more easily readable in the html, but I don't think that's a big deal.
Issue(s) Resolved
Page is big sometimes, saves data.
Test Plan
Should probably do a full test of the app, but in principle this should not change anything!
Screenshots (if applicable)
Optional
Notes/Context/Gotchas
Supporting Docs