Skip to content

RFC: serialize initial data more efficiently to reduce HTML page size by up to 30% uncompressed/17% compressed #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tefkah merged 2 commits into from
Dec 12, 2023
Merged

RFC: serialize initial data more efficiently to reduce HTML page size by up to 30% uncompressed/17% compressed #2921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73ca5be
feat: change hydration data to be smaller
tefkah Nov 21, 2023
ca1cf83
feat: really minify body
tefkah Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/utils/hydrateWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ export const hydrateWrapper = (Component) => {
}

// @ts-expect-error ts-migrate(2531) FIXME: Object is possibly 'null'.
const viewData = JSON.parse(document.getElementById('view-data').getAttribute('data-json'));
const viewData = JSON.parse(document.getElementById('view-data')?.innerText);
const chunkName = JSON.parse(
// @ts-expect-error ts-migrate(2531) FIXME: Object is possibly 'null'.
document.getElementById('chunk-name').getAttribute('data-json'),
document.getElementById('chunk-name').innerText,
);
if (!isLocalEnv(window)) {
setupHeap(initialData);
Expand Down
2 changes: 1 addition & 1 deletion client/utils/initialData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ let initialData;
export const getClientInitialData = () => {
if (!initialData) {
// @ts-expect-error ts-migrate(2531) FIXME: Object is possibly 'null'.
initialData = JSON.parse(document.getElementById('initial-data').getAttribute('data-json'));
initialData = JSON.parse(document.getElementById('initial-data').innerText);
}
return initialData;
};
15 changes: 8 additions & 7 deletions server/Html.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import path from 'path';
import React from 'react';
import classNames from 'classnames';
import App from 'containers/App/App';
import { CustomScripts, InitialData } from 'types';
import type { CustomScripts, InitialData } from 'types';

const manifest = require(path.join(
__dirname,
Expand Down Expand Up @@ -123,19 +123,20 @@ const Html = (props: Props) => {
/>
<script
id="initial-data"
type="text/plain"
data-json={JSON.stringify(props.initialData)}
type="application/json"
dangerouslySetInnerHTML={{ __html: JSON.stringify(props.initialData) }}
/>
<script
id="view-data"
type="text/plain"
data-json={JSON.stringify(props.viewData)}
type="application/json"
dangerouslySetInnerHTML={{ __html: JSON.stringify(props.viewData) }}
/>
<script
id="chunk-name"
type="text/plain"
data-json={JSON.stringify(props.chunkName)}
type="application/json"
dangerouslySetInnerHTML={{ __html: JSON.stringify(props.chunkName) }}
/>

<script src={getPath('vendor', 'js')} />
<script src={getPath('main', 'js')} />
{customScripts?.js && (
Expand Down