fix: clear rawInput when removing repetition groups#446
Merged
Conversation
When a template form fails validation, Wicket retains each FormComponent's rawInput and uses it during re-render instead of the model value. Removing a repetition group then shifted model values down but left the original rawInput on the remaining TextFields, so the removed statement's placeholder value stayed visible at the slot that took its place (issue #445). Clear the rawInput of each FormComponent whose model was shifted so the new model value is actually rendered. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FormComponent'srawInputafter a failed validation and uses it for rendering instead of the model value.RepetitionGroup.remove()shifted model values down but didn't clear the stalerawInput, so the shifted-in value was masked.remove(), walkcontext.getComponents()and callclearInput()on anyFormComponentbound to the affected model.Test plan
🤖 Generated with Claude Code