refactor: drop formobj, use PageReference for preview Back#449
Merged
Conversation
The formobj query param plus session formMap was a workaround to make the Back button on PreviewPage reach the live PublishForm instance instead of reconstructing an empty one. Wicket already has a first-class mechanism for this: PageReference, backed by the page store. - PreviewNanopub carries a PageReference to the source PublishPage. - PreviewPage's Back button resolves it via setResponsePage(page), falling back to RestartResponseException(PublishPage.class, params) if the reference has expired from the page store. - PublishPage and GenPublishPage drop the formobj redirect and the session-cache lookup; they just instantiate PublishForm directly. - NanodashSession drops formMap, MAX_FORMS, the LRU eviction, and the set/has/get/remove form helpers. Closes #373. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3a5efea to
063c82c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the `formobj` query-param + session `formMap` workaround with Wicket's native `PageReference` for the "Back from preview" flow (see #373).
What changed
Why
Test plan
🤖 Generated with Claude Code