Merged
Conversation
The top-left menu items used './publish', './userlist', './spaces', './queries' as hrefs, which the browser resolved relative to the current URL. From a connector page like /connector/select, clicking "Publish" therefore hit /connector/publish (GenPublishPage) without the required template param and errored out (#450). - Replace the WebMarkupContainer nav slots with BookmarkablePageLink so Wicket generates absolute, page-class-aware URLs. - Change the static Home link href from "." to "/" so it also goes to the app root regardless of current URL. Fixes #450. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #450 — from `/connector/select?journal=...`, clicking the top-left "Publish" navigated to `/connector/publish` (`GenPublishPage`) with no `template` param and errored out.
Root cause: the nav menu items used `./publish`, `./userlist`, `./spaces`, `./queries` as hrefs. Browser URL resolution made them relative to the current page, so from any `/connector/*` URL they landed inside the connector tree instead of at the app root.
Test plan
🤖 Generated with Claude Code