Skip to content

fix: use absolute nav links in TitleBar #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkuhn merged 1 commit into from
Apr 22, 2026
+16 −10
Merged

fix: use absolute nav links in TitleBar #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/knowledgepixels/nanodash/component/TitleBar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<div class="logo-menu">
<span class="logo" onclick="toggleMobileNav()"></span>
<div class="logo-dropdown">
<a href=".">Home</a>
<a href="/">Home</a>
<a wicket:id="users" href="./userlist">Users</a>
<a wicket:id="connectors" href="./spaces">Spaces</a>
<a wicket:id="query" href="./queries">Query</a>
Expand Down
24 changes: 15 additions & 9 deletions src/main/java/com/knowledgepixels/nanodash/component/TitleBar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

import org.apache.wicket.behavior.AttributeAppender;
import org.apache.wicket.markup.html.WebMarkupContainer;
import org.apache.wicket.markup.html.WebPage;
import org.apache.wicket.markup.html.link.BookmarkablePageLink;
import org.apache.wicket.markup.html.panel.Panel;
import org.apache.wicket.markup.repeater.Item;
import org.apache.wicket.markup.repeater.data.DataView;
Expand All @@ -14,6 +16,10 @@
import com.knowledgepixels.nanodash.NanodashPreferences;
import com.knowledgepixels.nanodash.Utils;
import com.knowledgepixels.nanodash.page.NanodashPage;
import com.knowledgepixels.nanodash.page.PublishPage;
import com.knowledgepixels.nanodash.page.QueryListPage;
import com.knowledgepixels.nanodash.page.SpaceListPage;
import com.knowledgepixels.nanodash.page.UserListPage;

/**
* TitleBar is the top bar of the Nanodash application, which contains
Expand All @@ -38,10 +44,10 @@ public TitleBar(String id, NanodashPage page, String highlight, NanodashPageRef.
this.highlight = highlight;
add(new ProfileItem("profile", page));

createContainer("users");
createContainer("connectors");
createContainer("publish").setVisible(!NanodashPreferences.get().isReadOnlyMode());
createContainer("query");
createNavLink("users", UserListPage.class);
createNavLink("connectors", SpaceListPage.class);
createNavLink("publish", PublishPage.class).setVisible(!NanodashPreferences.get().isReadOnlyMode());
createNavLink("query", QueryListPage.class);

WebMarkupContainer breadcrumbPath = new WebMarkupContainer("breadcrumbpath");
breadcrumbPath.setVisible(pathRefs.length > 0);
Expand Down Expand Up @@ -125,13 +131,13 @@ private static String stripParentPrefix(String parent, String child) {
return remainder;
}

private WebMarkupContainer createContainer(String id) {
WebMarkupContainer c = new WebMarkupContainer(id);
private BookmarkablePageLink<Void> createNavLink(String id, Class<? extends WebPage> pageClass) {
BookmarkablePageLink<Void> link = new BookmarkablePageLink<>(id, pageClass);
if (id.equals(highlight)) {
c.add(new AttributeAppender("class", "selected"));
link.add(new AttributeAppender("class", "selected"));
}
add(c);
return c;
add(link);
return link;
}

}