Skip to content

Conversation

@rgraber
Copy link
Contributor

@rgraber rgraber commented Dec 12, 2025

🗒️ Checklist

  1. run linter locally
  2. update developer docs (API, README, inline, etc.), if any
  3. for user-facing doc changes create a Zulip thread at #Support Docs Updates, if any
  4. draft PR with a title <type>(<scope>)<!>: <title> DEV-1234
  5. assign yourself, tag PR: at least Front end and/or Back end or workflow
  6. fill in the template below and delete template comments
  7. review thyself: read the diff and repro the preview as written
  8. open PR & confirm that CI passes & request reviewers, if needed
  9. delete this section before merging

📣 Summary

Validate params before creating new advanced features.

👀 Preview steps

  1. ℹ️ have an account and a project
  2. `curl -X POST -H 'Authorization: Token ' http://kf.kobo.local/api/v2/assets/<asset_uid>/advanced-features --json '{"question_xpath": , "action": "manual_transcription", "params": [{"something":"bad"}]}'
  3. 🔴 [on refactor-subsequences-2025] request 500s
  4. 🟢 [on PR] request 400s

@rgraber rgraber force-pushed the beccagraber/dev-1441-cannot-create-bad-features branch from a7fe88f to 2532d83 Compare December 12, 2025 13:18
@rgraber rgraber changed the title fix(subsequences): do not allow creation of features with incorrect params DEV-1441 fix(subsequences): better error from creation of features with incorrect params DEV-1441 Dec 12, 2025
@rgraber rgraber self-assigned this Dec 12, 2025
@rgraber rgraber marked this pull request as ready for review December 12, 2025 13:59
@rgraber rgraber requested a review from Guitlle as a code owner December 12, 2025 13:59
@rgraber rgraber removed the request for review from Guitlle December 12, 2025 13:59
@Guitlle Guitlle self-requested a review December 12, 2025 14:22
@rgraber rgraber merged commit 8dbe383 into refactor-subsequences-2025 Dec 12, 2025
10 of 11 checks passed
@rgraber rgraber deleted the beccagraber/dev-1441-cannot-create-bad-features branch December 12, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants