inputview: implement autogrow for single line inputs#155
inputview: implement autogrow for single line inputs#155gokmen merged 3 commits intokoding:masterfrom
Conversation
|
|
| @_clone = $ '<div/>', { class: 'invisible' } | ||
|
|
||
| { type } = @getOptions() | ||
| isVertical = type.toLowerCase() is 'textarea' |
There was a problem hiding this comment.
Why not accepting this as an option?
There was a problem hiding this comment.
isn't it an option already?
There was a problem hiding this comment.
operation we are making is named isVertical, but the option we are passing is textarea. Can't an input/textarea autogrow both vertically and horizontally?
There was a problem hiding this comment.
Assumption we did earlier was to use autogrow only for textareas and just vertically, now we expand the functionality to text inputs basically, but they can only grow horizontally. That's why I didn't think another option was necessary.
However I didn't think about a bidirectional growing input, never needed that. Do you think it is necessary?
There was a problem hiding this comment.
Nope, I don't think so. Only the assumption we make made me confused.
3 participants
cc/ @usirin