This repository was archived by the owner on Nov 25, 2020. It is now read-only.
Conversation
sinan
added a commit
that referenced
this pull request
Apr 20, 2015
CustomScroll: removed nested hidden overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds karma for automatically running tests locally (Chrome and Firefox) and remotely on SauceLabs (Chrome, Firefox, IE9, IE10).
Also updates the parts of the gulp build that were causing trouble with karma (in particular slow builds using deprecated gulp-browserify plugin.)
Where should the reviewer start?
readme.md and gulpfile.coffee
You'll also need to
npm installsince there are new dev dependenciesHow should this be manually tested?
Take a look at additions to readme.md, then run karma locally and on sauce. If you can't get this up and running from the readme instructions is means that I have more work to do! And don't forget to nuke your node_modules directory before you
npm installif you want to get rid of extraneous modules.