Skip to content
This repository was archived by the owner on Nov 25, 2020. It is now read-only.

splitview: add an option to forceResize all panels#95

Merged
fatihacet merged 2 commits intokoding:masterfrom
usirin:split-resize-panel
Nov 21, 2014
Merged

splitview: add an option to forceResize all panels#95
fatihacet merged 2 commits intokoding:masterfrom
usirin:split-resize-panel

Conversation

@usirin
Copy link
Copy Markdown
Contributor

@usirin usirin commented Nov 21, 2014

This PR solves the following problem via adding another parameter called forceResize to the _calculateSize method.

  • When left/top panel reaches the required size it returns early even though the other panel still needs resizing. This gives another option to discard that situation and resize the panels no matter what.

I know this is kind of a dirty solution, but I am taking notes of these kind of situations, and will try to address them in a proper way, hopefully, when we rewrite/refactor these components. Also, this kind of modification gives us a way to solve those kind of problems without breaking backwards compatibility.

fatihacet added a commit that referenced this pull request Nov 21, 2014
splitview: add an option to forceResize all panels
@fatihacet fatihacet merged commit 3fa6959 into koding:master Nov 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants