add a pull request template and CODEOWNERS - #230
Conversation
📝 WalkthroughWalkthroughThe repository assigns a global code owner and adds a pull request template for Docker image contributions. The template requests a description, motivation, image testing, ChangesRepository contribution governance
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/pull_request_template.md:
- Line 13: Update the Goss checklist item in the pull request template to
mention processes and command outputs alongside files, ports, and packages,
preserving the existing conditional wording.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f9f6873a-305e-4880-bec3-6d6441b2c22e
📒 Files selected for processing (2)
.github/CODEOWNERS.github/pull_request_template.md
|
|
||
| ## Checklist | ||
| - [ ] I've tested my changes against a built image | ||
| - [ ] I've updated `goss.yaml` if the change affects files, ports or packages in the image |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Include processes and command outputs in the Goss checklist.
AGENTS.md:31-34 states that Goss checks files, ports, processes, and command outputs. This checklist names only files, ports, and packages. Update the condition to include processes and command outputs.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/pull_request_template.md at line 13, Update the Goss checklist item
in the pull request template to mention processes and command outputs alongside
files, ports, and packages, preserving the existing conditional wording.
This repo has issue templates but no pull request template and no
CODEOWNERS, so contributor PRs arrive with a bare description and request nobody's review. koel/koel has both; this repo was set up separately and never got them.CODEOWNERSis* @phanan, matching koel/koel. It requests review automatically on every PR — worth noting it does not populate the Assignees field, which GitHub never fills in on its own; a review request is what drives the notification.The pull request template follows koel/koel's, with the Screenshots section dropped (rarely meaningful for an image build) and the testing checklist adjusted to what matters here: testing against a built image, and updating
goss.yamlwhen the change affects files, ports or packages.Summary by CodeRabbit