Skip to content

Remove bower. Fetch plyr from npm instead#235

Closed
rundef wants to merge 4 commits intokoel:masterfrom
rundef:small-improvements
Closed

Remove bower. Fetch plyr from npm instead#235
rundef wants to merge 4 commits intokoel:masterfrom
rundef:small-improvements

Conversation

@rundef
Copy link
Copy Markdown
Contributor

@rundef rundef commented Feb 16, 2016

Hey,

I discovered this app recently and I love it. Thought I could help. This should close #227

@lukasmalkmus
Copy link
Copy Markdown

Hope this gets merged :) 👍

@phanan
Copy link
Copy Markdown
Member

phanan commented Feb 17, 2016

Thanks for the PR. Couple of issues:

  • You are targetting multiple issues with one PR. Please consider separate them into multiple PR's.
  • With each fix/feature, please squash into one commit only.
  • What's the motivation behind changing the plyer class names in the scss file?

@rundef
Copy link
Copy Markdown
Contributor Author

rundef commented Feb 17, 2016

Sure, I can do one PR/Commit per issue. Should we close this one and I can create 3 PRs later ?

For the plyer class names, I believe koel was using version 1.3.6, but plyr has only been on npm since v1.5.9 ... One of the changes they made was to change their class names from .player* to .plyr*, so I made the necessary adjustements in Koel's css, and copied the scss from their package.

@phanan
Copy link
Copy Markdown
Member

phanan commented Feb 17, 2016

Yeah, please create individual commits, thanks.

On Wed, Feb 17, 2016 at 10:57 PM, Mickael Burguet notifications@github.com
wrote:

Sure, I can do one PR/Commit per issue. Should we close this one and I can
create 3 PRs later ?

For the plyer class names, I believe koel was using version 1.3.6, but
plyr has only been on npm since v1.5.9 ... One of the changes they made was
to change their class names from .player* to .plyr*, so I made the
necessary adjustements in Koel's css, and copied the scss from their
package.


Reply to this email directly or view it on GitHub
#235 (comment).

@rundef rundef closed this Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove bower completely

3 participants