Remove bower. Fetch plyr from npm instead#235
Remove bower. Fetch plyr from npm instead#235rundef wants to merge 4 commits intokoel:masterfrom rundef:small-improvements
Conversation
|
Hope this gets merged :) 👍 |
|
Thanks for the PR. Couple of issues:
|
|
Sure, I can do one PR/Commit per issue. Should we close this one and I can create 3 PRs later ? For the plyer class names, I believe koel was using version 1.3.6, but plyr has only been on npm since v1.5.9 ... One of the changes they made was to change their class names from .player* to .plyr*, so I made the necessary adjustements in Koel's css, and copied the scss from their package. |
|
Yeah, please create individual commits, thanks. On Wed, Feb 17, 2016 at 10:57 PM, Mickael Burguet notifications@github.com
|
Hey,
I discovered this app recently and I love it. Thought I could help. This should close #227