Disable no_unique_address for NVCC and CUDA 12.9 - #435
Merged
crtrott merged 1 commit intoOct 30, 2025
Conversation
Member
Author
|
@dalg24 may I get your review please ? |
Member
|
Deferring to Christian who owns that code and who should be able to reproduce without fighting with machine access. |
Member
|
Hm I don't even get there. For me the compiler crashes. |
Member
|
This change fixes the compiler crash I see with CUDA 12.9 and GCC 11.5 as host compiler. Testing then passes. I don't see issues with CUDA 12.8. |
crtrott
approved these changes
Oct 30, 2025
Member
Author
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #434, I need to disable
[[no_unique_address]]to make the Kokkos tests pass on a CUDA 12.9 environment on a CEA computer.With
[[no_unique_address]]I have the following errors: