fix: upgrade build JVM to Java 17 - #10
Merged
Merged
Conversation
Signed-off-by: Oleksandr Kolodkin <oleksandr.kolodkin@ukr.net>
OWASP dependency-check-gradle 12.2.2 and Kotlin 2.4.0 both require JVM 11+. Output bytecode target remains Java 8 via sourceCompatibility. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the build/CI environment to use a newer JVM (Java 17) while keeping the project’s compiled bytecode target at Java 8, enabling Gradle to load newer plugins (e.g., dependency-check 12.2.2 and Kotlin 2.4.0).
Changes:
- Added Gradle wrapper hardening settings (
networkTimeout,validateDistributionUrl) ingradle-wrapper.properties. - Updated GitHub Actions workflow to install/build with JDK 17 instead of JDK 8.
- Adjusted the OWASP dependency-check invocation flags in CI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
gradle/wrapper/gradle-wrapper.properties |
Adds wrapper configuration to improve wrapper download behavior and URL validation. |
.github/workflows/github-actions-java8.yml |
Switches CI build JVM to Java 17 and tweaks dependency-check execution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
68
to
+70
| - name: Run OWASP dependency check | ||
| if: matrix.os == 'windows-latest' # Only run on one platform | ||
| run: ./gradlew dependencyCheckAnalyze --no-daemon --stacktrace --continue | ||
| run: ./gradlew dependencyCheckAnalyze --no-daemon --stacktrace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
java-version: "8"to"17"so Gradle can loaddependency-check-gradle:12.2.2and Kotlin 2.4.0, both of which require JVM 11+sourceCompatibility = JavaVersion.VERSION_1_8andJvmTarget.JVM_1_8inbuild.gradle.ktsremain in placeTest plan
🤖 Generated with Claude Code